Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #110

Merged
merged 16 commits into from
Dec 10, 2024
Merged

V2 #110

merged 16 commits into from
Dec 10, 2024

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Dec 10, 2024

Important

Update version to 2.2.0 and enhance API with new fields and mandatory parameters in various request and response types.

  • Version Update:
    • Update version to 2.2.0 in package.json and multiple Client.ts files.
  • API Changes:
    • CreateGroupRequest now requires groupId.
    • AddMemoryRequest includes optional returnContext.
    • ApidataAddMemoryResponse added with optional context field.
    • User type now includes factRatingInstruction.
  • Serialization:
    • Update serialization for CreateGroupRequest and AddMemoryRequest to reflect new fields.
    • Add serialization for ApidataAddMemoryResponse.
  • Misc:
    • Minor docstring updates in Graph.ts and GraphSearchQuery.ts.

This description was created by Ellipsis for 5beb828. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5beb828 in 1 minute and 0 seconds

More details
  • Looked at 809 lines of code in 20 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. src/api/resources/group/client/Client.ts:43
  • Draft comment:
    Avoid using default empty object for request parameter. It may lead to runtime errors since CreateGroupRequest has required fields.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. src/api/resources/memory/client/Client.ts:1425
  • Draft comment:
    Avoid using default empty object for request parameter. It may lead to runtime errors if AddMemoryRequest has required fields.
  • Reason this comment was not posted:
    Comment was on unchanged code.
3. src/api/resources/graph/client/requests/GraphSearchQuery.ts:15
  • Draft comment:
    Ensure the comment starts with a capital letter for consistency and clarity.
    /** One of user_id or group_id must be provided */
  • Reason this comment was not posted:
    Comment did not seem useful.
4. src/api/resources/graph/client/requests/GraphSearchQuery.ts:30
  • Draft comment:
    Ensure the comment starts with a capital letter for consistency and clarity.
    /** One of user_id or group_id must be provided */
  • Reason this comment was not posted:
    Marked as duplicate.
5. src/api/resources/group/client/requests/CreateGroupRequest.ts:15
  • Draft comment:
    Ensure the comment is concise and clear.
    /** User IDs */
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_RJg3yJKG82jVHcx0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit c4f4549 into main Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant