Simplify field validation #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves getgrav#99, simplifies structure and method.
|
@OleVik Works in Chrome and IE! In Firefox: Edit: When you pass in the 'event', the error doesn't occure. I commented your file... |
core77
suggested changes
Mar 15, 2017
| }, false); | ||
| } | ||
|
|
||
| <form name="search" onSubmit="return validateSearch();"> |
There was a problem hiding this comment.
Should be return validateSearch(event);
|
|
||
| </form> | ||
| <script> | ||
| function validateSearch() { |
There was a problem hiding this comment.
Should be function validateSearch(event) {
|
@core77 thanks for testing and mentioning that, fixing after merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #99, clicking the button will allow the form to be submitted. This seems to be because
event.preventDefault();will not work properly when declared multiple times. For semantics and accessibility I wrapped the input- and button-tags in a form-tag, explicitly declared a button-type, and check the submission against a simpleonSubmit.It remains pure JavaScript, but is comparatively simpler in that it needs no
addEventListenerfor keyup or onclick, only onsubmit. HTML-structure is slightly simplified for readability. Tested with Grav v1.1.18 (from source) and plugin v1.10.0. @core77, mind testing it?