Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button is ignoring min_query_length #99

Closed
core77 opened this issue Feb 22, 2017 · 2 comments
Closed

Button is ignoring min_query_length #99

core77 opened this issue Feb 22, 2017 · 2 comments

Comments

@core77
Copy link

core77 commented Feb 22, 2017 •
edited
Loading

When the search field is empty and you press the search button the 404 page (not found) appears.

When pressing the enter key, this doesn't happen.

GRAV v1.1.17
SimpleSearch v1.10.0
@OleVik
Copy link
Contributor

OleVik commented Feb 23, 2017

Can replicate with the same Grav and SimpleSearch, event.preventDefault(); is not firing on an empty field as it should. It still navigates to search/query:.

OleVik added a commit to OleVik/grav-plugin-simplesearch that referenced this issue Feb 23, 2017
@OleVik
Simplify field validation
4011fa8 
Solves getgrav#99, simplifies structure and method.
@OleVik OleVik mentioned this issue Feb 23, 2017
Merged
flaviocopes pushed a commit that referenced this issue Apr 11, 2017
@OleVik @flaviocopes
Simplify field validation (#100)
ad97a0b 
Solves #99, simplifies structure and method.
@flaviocopes
Copy link
Contributor

Thanks @OleVik for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OleVik @core77 @flaviocopes