Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: launch code review #144

Merged
merged 40 commits into from
Aug 31, 2021
Merged

chore: launch code review #144

merged 40 commits into from
Aug 31, 2021

Conversation

jak-pan
Copy link
Contributor

@jak-pan jak-pan commented Aug 29, 2021

No description provided.

@codecov
Copy link

codecov bot commented Aug 29, 2021 •
edited
Loading

Codecov Report

Merging #144 (a874727) into master (9fd538c) will increase coverage by 0.17%.
The diff coverage is 90.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   85.98%   86.15%   +0.17%     
==========================================
  Files          21       21              
  Lines        2091     2117      +26     
==========================================
+ Hits         1798     1824      +26     
  Misses        293      293
Impacted Files Coverage Δ
pallets/duster/src/lib.rs 84.90% <0.00%> (-3.78%) ⬇️
primitives/src/traits.rs 71.42% <50.00%> (ø)
pallets/asset-registry/src/lib.rs 91.07% <85.00%> (+2.39%) ⬆️
pallets/asset-registry/src/benchmarking.rs 100.00% <100.00%> (ø)
pallets/duster/src/benchmarking.rs 100.00% <100.00%> (ø)
pallets/lbp/src/lib.rs 88.04% <100.00%> (+0.14%) ⬆️
pallets/xyk/src/lib.rs 83.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd538c...a874727. Read the comment docs.

jak-pan
jak-pan commented Aug 29, 2021
View reviewed changes
runtime/src/lib.rs Outdated Show resolved Hide resolved
jak-pan
jak-pan commented Aug 29, 2021
View reviewed changes
runtime/src/lib.rs Outdated Show resolved Hide resolved
jak-pan
jak-pan commented Aug 29, 2021
View reviewed changes
runtime/src/lib.rs Outdated Show resolved Hide resolved
@enthusiastmartin enthusiastmartin mentioned this pull request Aug 30, 2021
Closed
jak-pan
jak-pan commented Aug 30, 2021
View reviewed changes
primitives/src/traits.rs Outdated Show resolved Hide resolved
jak-pan
jak-pan commented Aug 30, 2021
View reviewed changes
pallets/lbp/src/lib.rs Outdated Show resolved Hide resolved
jak-pan
jak-pan commented Aug 30, 2021
View reviewed changes
runtime/src/lib.rs Outdated Show resolved Hide resolved
jak-pan
jak-pan commented Aug 30, 2021
View reviewed changes
Copy link
Contributor Author

@jak-pan jak-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrq1911 mrq1911 marked this pull request as ready for review August 30, 2021 23:22
@mrq1911 mrq1911 merged commit 6c25c50 into master Aug 31, 2021
@mrq1911 mrq1911 deleted the launch-review branch October 4, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@green-jay green-jay green-jay left review comments

@enthusiastmartin enthusiastmartin enthusiastmartin left review comments

@mrq1911 mrq1911 mrq1911 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jak-pan @mrq1911 @enthusiastmartin @green-jay @Roznovjak