chore: launch code review

.github/workflows/tests.yml

@@ -104,8 +104,8 @@ jobs:
       - name: Upload release wasm
         uses: actions/upload-artifact@v2
         with:
-          name: basilisk_runtime.wasm
-          path: target/release/wbuild/basilisk-runtime/basilisk_runtime.compact.wasm
+          name: basilisk_runtime.compact.compressed.wasm
+          path: target/release/wbuild/basilisk-runtime/basilisk_runtime.compact.compressed.wasm
 
   destroy-runner-instance:
     name: destroy infra

README.md

@@ -70,81 +70,138 @@ Then open settings screen -> developer and paste
 
 ```
 {
-  "AssetPair": {
-    "asset_in": "AssetId",
-    "asset_out": "AssetId"
+  "alias":{
+    "tokens":{
+      "AccountData":"OrmlAccountData"
+    }
   },
-  "Amount": "i128",
-  "AmountOf": "Amount",
-  "Address": "AccountId",
-  "OrmlAccountData": {
-    "free": "Balance",
-    "frozen": "Balance",
-    "reserved": "Balance"
-  },
-  "Fee": {
-    "numerator": "u32",
-    "denominator": "u32"
-  },
-  "BalanceInfo": {
-    "amount": "Balance",
-    "assetId": "AssetId"
-  },
-  "Chain": {
-    "genesisHash": "Vec<u8>",
-    "lastBlockHash": "Vec<u8>"
-  },
-  "CurrencyId": "AssetId",
-  "CurrencyIdOf": "AssetId",
-  "Intention": {
-    "who": "AccountId",
-    "asset_sell": "AssetId",
-    "asset_buy": "AssetId",
-    "amount": "Balance",
-    "discount": "bool",
-    "sell_or_buy": "IntentionType"
-  },
-  "IntentionId": "Hash",
-  "IntentionType": {
-    "_enum": [
-      "SELL",
-      "BUY"
-    ]
-  },
-  "LookupSource": "AccountId",
-  "Price": "Balance",
-  "ClassId": "u64",
-  "TokenId": "u64",
-  "ClassData": {
-    "is_pool": "bool"
-  },
-  "TokenData": {
-    "locked": "bool"
-  },
-  "CID": "Vec<u8>",
-  "ClassInfo": {
-    "metadata": "Vec<u8>",
-    "total_issuance": "TokenId",
-    "owner": "AccountId",
-    "data": "ClassData"
-  },
-  "TokenInfo": {
-    "metadata": "Vec<u8>",
-    "owner": "AccountId",
-    "data": "TokenData"
-  },
-  "ClassInfoOf": "ClassInfo",
-  "TokenInfoOf": "TokenInfo",
-  "ClassIdOf": "ClassId",
-  "TokenIdOf": "TokenId",
-  "OrderedSet": "Vec<AssetId>",
-  "VestingSchedule": {
-    "start": "BlockNumber",
-    "period": "BlockNumber",
-    "period_count": "u32",
-    "per_period": "Compact<Balance>"
-  },
-  "VestingScheduleOf": "VestingSchedule"
+  "types":[
+    {
+      "AssetPair":{
+        "asset_in":"AssetId",
+        "asset_out":"AssetId"
+      },
+      "Amount":"i128",
+      "AmountOf":"Amount",
+      "Address":"AccountId",
+      "OrmlAccountData":{
+        "free":"Balance",
+        "frozen":"Balance",
+        "reserved":"Balance"
+      },
+      "Fee":{
+        "numerator":"u32",
+        "denominator":"u32"
+      },
+      "BalanceInfo":{
+        "amount":"Balance",
+        "assetId":"AssetId"
+      },
+      "Chain":{
+        "genesisHash":"Vec<u8>",
+        "lastBlockHash":"Vec<u8>"
+      },
+      "Currency":"AssetId",
+      "CurrencyId":"AssetId",
+      "CurrencyIdOf":"AssetId",
+      "Intention":{
+        "who":"AccountId",
+        "asset_sell":"AssetId",
+        "asset_buy":"AssetId",
+        "amount":"Balance",
+        "discount":"bool",
+        "sell_or_buy":"IntentionType"
+      },
+      "IntentionId":"Hash",
+      "IntentionType":{
+        "_enum":[
+          "SELL",
+          "BUY"
+        ]
+      },
+      "LookupSource":"AccountId",
+      "Price":"Balance",
+      "ClassId":"u64",
+      "TokenId":"u64",
+      "ClassData":{
+        "is_pool":"bool"
+      },
+      "TokenData":{
+        "locked":"bool"
+      },
+      "ClassInfo":{
+        "metadata":"Vec<u8>",
+        "total_issuance":"TokenId",
+        "owner":"AccountId",
+        "data":"ClassData"
+      },
+      "TokenInfo":{
+        "metadata":"Vec<u8>",
+        "owner":"AccountId",
+        "data":"TokenData"
+      },
+      "ClassInfoOf":"ClassInfo",
+      "TokenInfoOf":"TokenInfo",
+      "ClassIdOf":"ClassId",
+      "TokenIdOf":"TokenId",
+      "OrderedSet":"Vec<AssetId>",
+      "VestingSchedule":{
+        "start":"BlockNumber",
+        "period":"BlockNumber",
+        "period_count":"u32",
+        "per_period":"Compact<Balance>"
+      },
+      "VestingScheduleOf":"VestingSchedule",
+      "LBPAssetInfo":{
+        "id":"AssetId",
+        "amount":"Balance",
+        "initial_weight":"LBPWeight",
+        "final_weight":"LBPWeight"
+      },
+      "LBPWeight":"u128",
+      "WeightPair":{
+        "weight_a":"LBPWeight",
+        "weight_b":"LBPWeight"
+      },
+      "WeightCurveType":{
+        "_enum":[
+          "Linear"
+        ]
+      },
+      "PoolId":"AccountId",
+      "BalanceOf":"Balance",
+      "AssetType":{
+        "_enum":[
+          "Token"
+        ]
+      },
+      "Pool":{
+        "owner":"AccountId",
+        "start":"BlockNumber",
+        "end":"BlockNumber",
+        "assets":"AssetPair",
+        "initial_weights":"WeightPair",
+        "final_weights":"WeightPair",
+        "last_weight_update":"BlockNumber",
+        "last_weights":"WeightPair",
+        "weight_curve":"WeightCurveType",
+        "pausable":"bool",
+        "paused":"bool",
+        "fee":"Fee",
+        "fee_receiver":"AccountId"
+      },
+      "AssetNativeLocation":"MultiLocation",
+      "AssetDetails":{
+        "name":"Vec<u8>",
+        "asset_type":"AssetType",
+        "locked":"bool"
+      },
+      "AssetMetadata":{
+        "symbol":"Vec<u8>",
+        "decimals":"u8"
+      }
+    }
+  ]
 }
 ```
 

node/src/chain_spec.rs

@@ -4,7 +4,7 @@ use basilisk_runtime::{
 	AccountId, AssetRegistryConfig, AuraId, Balance, BalancesConfig, CollatorSelectionConfig, CouncilConfig,
 	DusterConfig, ElectionsConfig, GenesisConfig, MultiTransactionPaymentConfig, OrmlNftConfig, ParachainInfoConfig,
 	SessionConfig, Signature, SudoConfig, SystemConfig, TechnicalCommitteeConfig, TokensConfig, VestingConfig, BSX,
-	WASM_BINARY,
+	WASM_BINARY, NATIVE_EXISTENTIAL_DEPOSIT
 };
 use cumulus_primitives_core::ParaId;
 use hex_literal::hex;
@@ -210,7 +210,12 @@ pub fn testnet_parachain_config(para_id: ParaId) -> Result<ChainSpec, String> {
 				vec![hex!["30035c21ba9eda780130f2029a80c3e962f56588bc04c36be95a225cb536fb55"].into()],
 				hex!["30035c21ba9eda780130f2029a80c3e962f56588bc04c36be95a225cb536fb55"].into(), // SAME AS ROOT
 				vec![].into(),
-				vec![b"hKSM".to_vec(), b"hDOT".to_vec(), b"hETH".to_vec(), b"hUSDT".to_vec()],
+				vec![
+					(b"hKSM".to_vec(), 1_000u128),
+					(b"hDOT".to_vec(), 1_000u128),
+					(b"hETH".to_vec(), 1_000u128),
+					(b"hUSDT".to_vec(), 1_000u128),
+				],
 			)
 		},
 		// Bootnodes
@@ -293,7 +298,12 @@ pub fn parachain_development_config(para_id: ParaId) -> Result<ChainSpec, String
 				],
 				get_account_id_from_seed::<sr25519::Public>("Alice"), // SAME AS ROOT
 				get_vesting_config_for_test(),
-				vec![b"hKSM".to_vec(), b"hDOT".to_vec(), b"hETH".to_vec(), b"hUSDT".to_vec()],
+				vec![
+					(b"hKSM".to_vec(), 1_000u128),
+					(b"hDOT".to_vec(), 1_000u128),
+					(b"hETH".to_vec(), 1_000u128),
+					(b"hUSDT".to_vec(), 1_000u128),
+				],
 			)
 		},
 		// Bootnodes
@@ -437,7 +447,12 @@ pub fn local_parachain_config(para_id: ParaId) -> Result<ChainSpec, String> {
 				],
 				get_account_id_from_seed::<sr25519::Public>("Alice"), // SAME AS ROOT
 				get_vesting_config_for_test(),
-				vec![b"hKSM".to_vec(), b"hDOT".to_vec(), b"hETH".to_vec(), b"hUSDT".to_vec()],
+				vec![
+					(b"hKSM".to_vec(), 1_000u128),
+					(b"hDOT".to_vec(), 1_000u128),
+					(b"hETH".to_vec(), 1_000u128),
+					(b"hUSDT".to_vec(), 1_000u128),
+				],
 			)
 		},
 		// Bootnodes
@@ -516,6 +531,7 @@ fn parachain_genesis(
 		asset_registry: AssetRegistryConfig {
 			asset_names: vec![],
 			native_asset_name: TOKEN_SYMBOL.as_bytes().to_vec(),
+			native_existential_deposit: NATIVE_EXISTENTIAL_DEPOSIT,
 		},
 		multi_transaction_payment: MultiTransactionPaymentConfig {
 			currencies: vec![],
@@ -572,7 +588,7 @@ fn testnet_parachain_genesis(
 	tech_committee_members: Vec<AccountId>,
 	tx_fee_payment_account: AccountId,
 	vesting_list: Vec<(AccountId, BlockNumber, BlockNumber, u32, Balance)>,
-	registered_assets: Vec<Vec<u8>>,
+	registered_assets: Vec<(Vec<u8>, Balance)>, // (Asset name, Existential deposit)
 ) -> GenesisConfig {
 	GenesisConfig {
 		system: SystemConfig {
@@ -617,6 +633,7 @@ fn testnet_parachain_genesis(
 		asset_registry: AssetRegistryConfig {
 			asset_names: registered_assets,
 			native_asset_name: TOKEN_SYMBOL.as_bytes().to_vec(),
+			native_existential_deposit: NATIVE_EXISTENTIAL_DEPOSIT,
 		},
 		multi_transaction_payment: MultiTransactionPaymentConfig {
 			currencies: vec![],

pallets/asset-registry/Cargo.toml

@@ -22,6 +22,9 @@ serde = { features = ["derive"], optional = true, version = "1.0.101" }
 # Local dependencies
 primitives = { path = "../../primitives", default-features = false }
 
+# ORML dependencies
+orml-traits = { git = "/~https://github.com/open-web3-stack/open-runtime-module-library", rev = "8d5432c3458702a7df14b374bddde43a2a20aa43", default-features = false }
+
 # Substrate dependencies
 frame-support = { git = "/~https://github.com/paritytech/substrate", branch = "polkadot-v0.9.9", default-features = false }
 frame-system = { git = "/~https://github.com/paritytech/substrate", branch = "polkadot-v0.9.9", default-features = false }