fix(--isolate): correctly handle staticcalls

[klkvr]

Motivation

Closes #9564

RIght now slots warmed by CALLs or test contract itself are never marked cold before STATICCALLs making gas usage of those affected by other calls.

This PR simply goes over state and marks everything cold before every STATICCALL if isolation is enabled

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[grandizzy]

makes sense! Just a note that there's a chance test-isolate CI job to fail but if so we can fix in subsequent PR

[klkvr]

@grandizzy yeah there's indeed a failure for arbitraryStorage cheatcode tests

it's happening because of this condition

foundry/crates/cheatcodes/src/inspector.rs

Line 1811 in e9df79c

if value.is_cold && value.data.is_zero() {

I believe the idea here is to only generate random value on first slot access. With --isolate we can't assume that slot will always be cold on first access, so I guess the only way to solve this would be to keep a separate track of slots which we shouldn't generate random values for

[grandizzy]

makes sense, we do have another similae cheatcode marked as not working with isolate https://book.getfoundry.sh/cheatcodes/mock-function#description so could be just a doc until then

[grandizzy]

@klkvr actually we already keep that mapping here:

foundry/crates/cheatcodes/src/inspector.rs

Lines 295 to 298 in bf9bd30

	/// Mapping of arbitrary storage addresses to generated values (slot, arbitrary value).
	/// (SLOADs return random value if storage slot wasn't accessed).
	/// Changed values are recorded and used to copy storage to different addresses.
	pub values: HashMap<Address, HashMap<U256, U256>>,

but I think is better just to ignore addresses with arbitraryStorage, I made a PR #9945 which is passing isolate tests: /~https://github.com/foundry-rs/foundry/actions/runs/13499915297