Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(isolate): do not mark cold accounts with arbitrary storage #9945

Merged
merged 1 commit into from
Feb 24, 2025
Merged

fix(isolate): do not mark cold accounts with arbitrary storage #9945

merged 1 commit into from
Feb 24, 2025

Conversation

grandizzy
Copy link
Collaborator

Motivation

Solution

  • do not mark as cold if address with arbitrary storage

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy mentioned this pull request Feb 24, 2025
Merged
3 tasks
@grandizzy grandizzy added the L-ignore Log: ignore PR in changelog label Feb 24, 2025
klkvr
klkvr approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this would mean that gas accounting would not be entirely precise in symbolic execution environments which is likely fine

@grandizzy grandizzy enabled auto-merge (squash) February 24, 2025 14:24
@grandizzy grandizzy merged commit 879154c into master Feb 24, 2025
47 checks passed
@grandizzy grandizzy deleted the grandizzy/isolate-arbitrary-storage branch February 24, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
L-ignore Log: ignore PR in changelog
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grandizzy @klkvr @zerosnacks