Fix NullPointerException thrown on startup #43293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54434417 |
Summary: We previously restricted all copies and moves of SyncCallback, but that led to unsafe calling paths being added instead to AsyncCallback. Instead, allowing moving of SyncCallback, and document the need for the caller to invoke it safely, so can we remove the unsafe path from AsyncCallback. Changelog: [General][Changed] Allow moving SyncCallback for advanced use-cases Reviewed By: christophpurrer Differential Revision: D54381734
…ok#43294) Summary: These are gated by `ReactFeatureFlags.enableBridgelessArchitecture` and are missing support. They should be evaluated for backwards compatibility Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D54422143
Summary: Was debugging this, and found that this exception was being thrown due to `DefaultBindingsInstaller`, which was an invalid hybrid object. The ReactInstance initializer fully supports this being null, so let's use that as default. Changelog: [Android][Fixed] NullPointerException is no longer ignored in MessageQueueThreadHandler Reviewed By: sammy-SC Differential Revision: D54434417
javache
force-pushed
the
export-D54434417
branch
from
7dadf14 to
d256ab5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54434417 |
Base commit: f5c8bc1 |
|
This pull request has been merged in 5f45700. |
huntie
pushed a commit
that referenced
this pull request
Mar 11, 2024
Summary: Pull Request resolved: #43293 Was debugging this, and found that this exception was being thrown due to `DefaultBindingsInstaller`, which was an invalid hybrid object. The ReactInstance initializer fully supports this being null, so let's use that as default. Changelog: [Android][Fixed] NullPointerException is no longer ignored in MessageQueueThreadHandler Reviewed By: sammy-SC Differential Revision: D54434417 fbshipit-source-id: 52417b390061eface0f0578e32796d3a85303e03
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Was debugging this, and found that this exception was being thrown due to
DefaultBindingsInstaller, which was an invalid hybrid object. The ReactInstance initializer fully supports this being null, so let's use that as default.Changelog: [Android][Fixed] NullPointerException is no longer ignored in MessageQueueThreadHandler
Differential Revision: D54434417