Add TODOs for missing ReactActivityDelegate methods #43294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54422143 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 4, 2024
Summary: These are gated by `ReactFeatureFlags.enableBridgelessArchitecture` and are missing support. They should be evaluated for backwards compatibility Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D54422143
javache
force-pushed
the
export-D54422143
branch
from
20cdf02 to
2c38f93
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54422143 |
Summary: We previously restricted all copies and moves of SyncCallback, but that led to unsafe calling paths being added instead to AsyncCallback. Instead, allowing moving of SyncCallback, and document the need for the caller to invoke it safely, so can we remove the unsafe path from AsyncCallback. Changelog: [General][Changed] Allow moving SyncCallback for advanced use-cases Reviewed By: christophpurrer Differential Revision: D54381734
Summary: These are gated by `ReactFeatureFlags.enableBridgelessArchitecture` and are missing support. They should be evaluated for backwards compatibility Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D54422143
javache
force-pushed
the
export-D54422143
branch
from
2c38f93 to
a56877c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54422143 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 4, 2024
…ok#43294) Summary: These are gated by `ReactFeatureFlags.enableBridgelessArchitecture` and are missing support. They should be evaluated for backwards compatibility Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D54422143
Base commit: f5c8bc1 |
|
This pull request has been merged in 24e6722. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These are gated by
ReactFeatureFlags.enableBridgelessArchitectureand are missing support. They should be evaluated for backwards compatibilityChangelog: [Internal]
Reviewed By: fkgozali
Differential Revision: D54422143