[GHA] Creating a new version only tracks relevant files to git #3306
Conversation
Fixes an issue where unrelated files were getting added to the `docusaurus-versions` branch. In particular the changes from running tutorials (the tutorials themselves, the dbs) were getting persisted and causing problems for future runs of the tutorials.
facebook-github-bot
added
the
CLA Signed
|
Couple more things will need to happen to fully fix this:
|
|
@CristianLara has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| @@ -75,7 +75,7 @@ jobs: | |||
| yarn | |||
| yarn docusaurus docs:version ${{ inputs.new_version }} | |||
| git add --all | |||
| git add versioned_docs/ versioned_sidebars/ versions.json | |||
There was a problem hiding this comment.
could have also just done git add . since these are the only modified files in the website/ directory... but after the previous bug I'd rather be as specific as possible
There was a problem hiding this comment.
And thanks to the merge in l42, we should always be up to date with main for the rest of the repo, so we won't fall behind anywhere else. Versioned docs are only generated as part of this workflow, so we don't have to worry about merge conflicts either.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3306 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 525 525
Lines 52467 52467
=======================================
Hits 50240 50240
Misses 2227 2227 ☔ View full report in Codecov by Sentry. |
| @@ -75,7 +75,7 @@ jobs: | |||
| yarn | |||
| yarn docusaurus docs:version ${{ inputs.new_version }} | |||
| git add --all | |||
| git add versioned_docs/ versioned_sidebars/ versions.json | |||
There was a problem hiding this comment.
And thanks to the merge in l42, we should always be up to date with main for the rest of the repo, so we won't fall behind anywhere else. Versioned docs are only generated as part of this workflow, so we don't have to worry about merge conflicts either.
|
@CristianLara merged this pull request in e2082ae. |
Summary: Fixes an issue where unrelated files could get added to the `docusaurus-versions` branch. This broke GHA in the Ax repo since this was adding the results of running tutorials. Botorch doesn't run tutorials in CI but we still fix this to avoid other possible issues down the road. Same fix as the Ax counterpart: facebook/Ax#3306 Pull Request resolved: #2726 Reviewed By: saitcakmak Differential Revision: D69128162 Pulled By: CristianLara fbshipit-source-id: 95c798cf5c10a1fe2ed21b719a64afdf8d53ff0e
Fixes an issue where unrelated files were getting added to the
docusaurus-versionsbranch. In particular the changes from running tutorials (the tutorials themselves, the dbs) were getting persisted and causing problems for future runs of the tutorials.