Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Creating a new version only tracks relevant files to git #2726

Closed
wants to merge 1 commit into from

Conversation

CristianLara
Copy link
Contributor

Fixes an issue where unrelated files could get added to the docusaurus-versions branch. This broke GHA in the Ax repo since this was adding the results of running tutorials. Botorch doesn't run tutorials in CI but we still fix this to avoid other possible issues down the road.

Same fix as the Ax counterpart: facebook/Ax#3306

Fixes an issue where unrelated files could gettinget added to the `docusaurus-versions` branch. This broke GHA in the Ax repo since this was adding the results of running tutorials. Botorch doesn't run tutorials in CI but we still fix this to avoid other possible issues down the road.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 4, 2025
@CristianLara
Copy link
Contributor Author

CristianLara commented Feb 4, 2025

Propagate this change to docusaurus-versions branch by catching it up with main once this lands.
- #2729

@facebook-github-bot
Copy link
Contributor

@CristianLara has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (3faf489) to head (8ce8562).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2726   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         203      203           
  Lines       18671    18671           
=======================================
  Hits        18670    18670           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@CristianLara merged this pull request in a972ae1.

@saitcakmak saitcakmak deleted the gha-deploy-dont-track-run-tutorials branch February 4, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants