Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial tracks support #4

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Initial tracks support #4

merged 7 commits into from
Jan 4, 2024

Conversation

nirvn
Copy link
Collaborator

@nirvn nirvn commented Dec 2, 2023

This PR implements support for tracks when calculating flight emission.

As seen in this plotting to vector layer, the flight emission footprint follows the defined track line (highlighted here in glowing pink):

image

Whereas without a defined track ID in the movements CSV file, the model reverts back to the old assumption that the airplane will fly off in a straight line:

image

More implementation details: as the track itself only defines x,y, and z coordinates, we have to take an aircraft profile to attach additional values. The way it's done here is that it'll pick the right aircraft profile (that would have been used to draw the straight line before), and attaches to each track point the extra details from the profile's nearest point.

@nirvn nirvn force-pushed the tracks branch 3 times, most recently from 6fb82ab to 14eba0a Compare December 6, 2023 08:55
@nirvn nirvn force-pushed the tracks branch 3 times, most recently from a3504bd to cc661f7 Compare December 17, 2023 08:35
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, cannot check the logic. One small comment on variable naming.

@nirvn nirvn merged commit a629b95 into main Jan 4, 2024
@suricactus suricactus deleted the tracks branch January 10, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants