Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

174 aircraft default profile fix #175

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

luipir
Copy link
Contributor

@luipir luipir commented Sep 5, 2024

fixes #174

default values in case of wrong profile_id were never applied due to AND condition i any Null/None value in profiles_id.
Fixed this and added more logging to warn the user when and where the default is applied and in case if not applicable than warn that related movement is not retained.

or skip if nor is possible to setup default value
Skip o apply default will be notifed as warning
@luipir luipir requested a review from suricactus September 5, 2024 15:29
@luipir
Copy link
Contributor Author

luipir commented Sep 6, 2024

agreed with @suricactus to merge to allow Stavros to test. Then a review will be available later

@luipir luipir merged commit a329d3f into main Sep 6, 2024
1 check passed
@luipir luipir deleted the 174_aircraft_default_profile_fix branch September 6, 2024 09:04
@luipir
Copy link
Contributor Author

luipir commented Sep 6, 2024

this is an example of the log in case of default is applied

05-09-2024 17:17:47 - DEBUG - open_alaqs.openalaqsuitoolkit : Styles applied to Area layer
05-09-2024 17:17:51 - INFO - open_alaqs.core.interfaces.Movement : Number of movements in the DB: 10
05-09-2024 17:17:51 - WARNING - open_alaqs.core.interfaces.Movement : Runway 28 was found in the DB multiple times.
05-09-2024 17:17:52 - WARNING - open_alaqs.core.interfaces.Movement : Track '' wasn't found in the DB
05-09-2024 17:17:52 - WARNING - open_alaqs.core.interfaces.Movement : Lack of profile_id: '' using default value: 'CRJ9-ER-D-1' for movements: [1]
05-09-2024 17:17:52 - WARNING - open_alaqs.core.interfaces.Movement : Lack of profile_id: '737500-D-1' using default value: 'A350-941-D-1' for movements: [4]
05-09-2024 17:17:52 - DEBUG - open_alaqs.core.interfaces.Movement : finished stage 1 (n=7) in 0:00:01.776951
05-09-2024 17:17:53 - INFO - open_alaqs.core.interfaces.Movement : Number of movements retained: 10
05-09-2024 17:17:53 - DEBUG - open_alaqs.core.interfaces.Movement : finished stage 2 (n=10) in 0:00:00.221569
05-09-2024 17:17:53 - DEBUG - open_alaqs.core.interfaces.Movement : finished stage 3 (n=10) in 0:00:00.011524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aircraft default profiles not used as intended
1 participant