Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing compaction-batch-limit to etcd v3.4 and v3.5 #19218

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

serathius
Copy link
Member

PR #19196 broke robustness test periodics.

/cc @ahrtr @siyuanfoundation @gangli113

@k8s-ci-robot
Copy link

@serathius: GitHub didn't allow me to request PR reviews from the following users: gangli113.

Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

PR #19196 broke robustness test periodics.

/cc @ahrtr @siyuanfoundation @gangli113

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (9da01a8) to head (8c989a1).
Report is 25 commits behind head on main.

Additional details and impacted files

see 32 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19218   +/-   ##
=======================================
  Coverage   68.76%   68.76%           
=======================================
  Files         420      420           
  Lines       35638    35649   +11     
=======================================
+ Hits        24506    24514    +8     
- Misses       9705     9713    +8     
+ Partials     1427     1422    -5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9da01a8...8c989a1. Read the comment docs.

@serathius serathius force-pushed the fix-selecting-experimental-flag branch from 4d0a5fa to 2ac891f Compare January 17, 2025 12:43
server/embed/config.go Outdated Show resolved Hide resolved
server/embed/config.go Outdated Show resolved Hide resolved
@ahrtr
Copy link
Member

ahrtr commented Jan 17, 2025

PR #19196 broke robustness test periodics.

Can we just fix the test (although it isn't clear how it affect the test)? I do not see any issue on the production code in previous PR #19196.

@serathius serathius changed the title Remove experimental flag from embed.Config Move experimental flag from embed.Config to configJSON to normalize the config. Jan 17, 2025
@serathius serathius force-pushed the fix-selecting-experimental-flag branch from 2ac891f to 3824aed Compare January 17, 2025 13:14
@serathius serathius changed the title Move experimental flag from embed.Config to configJSON to normalize the config. Fix passing compaction-batch-limit to etcd v3.4 and v3.5 Jan 17, 2025
@serathius serathius force-pushed the fix-selecting-experimental-flag branch from 3824aed to 4db379d Compare January 17, 2025 13:22
@serathius serathius force-pushed the fix-selecting-experimental-flag branch from 4db379d to bb26c63 Compare January 17, 2025 13:25
tests/framework/e2e/cluster.go Outdated Show resolved Hide resolved
tests/framework/e2e/cluster.go Outdated Show resolved Hide resolved
@serathius serathius force-pushed the fix-selecting-experimental-flag branch 2 times, most recently from f9e37d2 to b4a0981 Compare January 17, 2025 14:14
@serathius
Copy link
Member Author

/retest

1 similar comment
@serathius
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member Author

/retest

1 similar comment
@serathius
Copy link
Member Author

/retest

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius force-pushed the fix-selecting-experimental-flag branch from 5a19e11 to 8c989a1 Compare January 20, 2025 16:14
@k8s-ci-robot
Copy link

k8s-ci-robot commented Jan 20, 2025

@serathius: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-integration-4-cpu-amd64 8c989a1 link true /test pull-etcd-integration-4-cpu-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ahrtr
Copy link
Member

ahrtr commented Jan 20, 2025

@serathius Note that #19221 fixes the workflow failure.

@serathius serathius merged commit 5ccbeec into etcd-io:main Jan 20, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants