-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix passing compaction-batch-limit to etcd v3.4 and v3.5 #19218
Fix passing compaction-batch-limit to etcd v3.4 and v3.5 #19218
Conversation
@serathius: GitHub didn't allow me to request PR reviews from the following users: gangli113. Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 32 files with indirect coverage changes @@ Coverage Diff @@
## main #19218 +/- ##
=======================================
Coverage 68.76% 68.76%
=======================================
Files 420 420
Lines 35638 35649 +11
=======================================
+ Hits 24506 24514 +8
- Misses 9705 9713 +8
+ Partials 1427 1422 -5 Continue to review full report in Codecov by Sentry.
|
4d0a5fa
to
2ac891f
Compare
2ac891f
to
3824aed
Compare
3824aed
to
4db379d
Compare
4db379d
to
bb26c63
Compare
f9e37d2
to
b4a0981
Compare
/retest |
1 similar comment
/retest |
b4a0981
to
5a19e11
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
5a19e11
to
8c989a1
Compare
@serathius: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@serathius Note that #19221 fixes the workflow failure. |
PR #19196 broke robustness test periodics.
/cc @ahrtr @siyuanfoundation @gangli113