Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send/Receive Voice Assistant Audio Messages #854

Merged
merged 10 commits into from
Apr 7, 2024

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Apr 4, 2024

Along with new a new message to handle audio data, the voice_assistant_version on the DeviceInfo has been deprecated in favour of voice_assistant_feature_flags to let the client know the features that this device supports.

There is a voice_assistant_feature_flags_compat(ApiVersion) function that will return the flags, or convert the legacy version into flags for older devices.

Credit to @synesthesiam for starting this work.

Related PRs:

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7da8a35) to head (f406041).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #854   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2463      2497   +34     
=========================================
+ Hits          2463      2497   +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@synesthesiam synesthesiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Probably best to break out the end flag rather than relying on empty bytes.

@jesserockz
Copy link
Member Author

Looks good to me! Probably best to break out the end flag rather than relying on empty bytes.

@synesthesiam What do you mean? There is an end flag already in the Audio message...

@jesserockz jesserockz merged commit 27a968d into main Apr 7, 2024
10 checks passed
@jesserockz jesserockz deleted the synesthesiam-20240319-voice-assistant-audio branch April 7, 2024 22:44
@synesthesiam
Copy link
Contributor

I mean what you did (adding the flag) is better than what I had done 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants