-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send/Receive Voice Assistant Audio Messages #854
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 2463 2497 +34
=========================================
+ Hits 2463 2497 +34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Probably best to break out the end
flag rather than relying on empty bytes.
@synesthesiam What do you mean? There is an |
I mean what you did (adding the flag) is better than what I had done 😄 |
Along with new a new message to handle audio data, the
voice_assistant_version
on the DeviceInfo has been deprecated in favour ofvoice_assistant_feature_flags
to let the client know the features that this device supports.There is a
voice_assistant_feature_flags_compat(ApiVersion)
function that will return the flags, or convert the legacy version into flags for older devices.Credit to @synesthesiam for starting this work.
Related PRs: