Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send/receive Voice Assistant audio via ESPHome native API #114800

Merged
merged 13 commits into from
Apr 9, 2024
Merged

Send/receive Voice Assistant audio via ESPHome native API #114800

merged 13 commits into from
Apr 9, 2024

Conversation

jesserockz
Copy link
Member

Proposed change

ESPHome now supports sending and receiving the voice assistant audio via the native API instead of relying on a UDP server on a random port.

Home Assistant will still fallback to the UDP server if the device does not support audio via the API. This feature will be released in ESPHome 2023.4.0

Credit to @synesthesiam for starting this work.

Related PRs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 4, 2024

Hey there @OttoWinter, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

This was referenced Apr 4, 2024
Merged
Merged
@jesserockz jesserockz marked this pull request as draft April 4, 2024 05:27
@MartinHjelmare MartinHjelmare changed the title ESPHome: Send/receive Voice Assistant audio via ESPHome native API Send/receive Voice Assistant audio via ESPHome native API Apr 4, 2024
@synesthesiam
Copy link
Contributor

I can confirm this is working for me.

@jesserockz jesserockz marked this pull request as ready for review April 8, 2024 04:18
@jesserockz jesserockz marked this pull request as draft April 8, 2024 04:37
@jesserockz
Update tests
d26f878 
- Add more tests for API pipeline
- Convert some udp tests to use api pipeline
- Update fixtures for new device info flags
@jesserockz jesserockz marked this pull request as ready for review April 8, 2024 07:57
@jesserockz jesserockz closed this Apr 8, 2024
@jesserockz jesserockz reopened this Apr 8, 2024
@jesserockz
Copy link
Member Author

jesserockz commented Apr 8, 2024 •
edited
Loading

Not sure whats happening with the CI here...
codecov/codecov-action#1359

@balloob balloob merged commit 68384bb into dev Apr 9, 2024
63 of 65 checks passed
@balloob balloob deleted the esphome-protobuf-audio branch April 9, 2024 14:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

@OttoWinter OttoWinter Awaiting requested review from OttoWinter OttoWinter is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees

@bdraco bdraco

@OttoWinter OttoWinter

Labels
by-code-owner cla-signed has-tests integration: esphome new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jesserockz @synesthesiam @balloob @bdraco @OttoWinter