215 add unit test for visualisation functionalities #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntorresd
reviewed
Oct 29, 2024
ntorresd
reviewed
Oct 29, 2024
ntorresd
reviewed
Oct 29, 2024
ntorresd
reviewed
Oct 29, 2024
ntorresd
reviewed
Oct 29, 2024
ntorresd
reviewed
Oct 29, 2024
ntorresd
reviewed
Oct 29, 2024
ntorresd
reviewed
Oct 29, 2024
ntorresd
reviewed
Oct 29, 2024
ntorresd
reviewed
Oct 29, 2024
ntorresd
reviewed
Oct 30, 2024
ntorresd
reviewed
Oct 30, 2024
| model_type = "age" | ||
| ) | ||
|
|
||
| plot <- plot_rhats( |
There was a problem hiding this comment.
I just realized that there is not a export tag for this function. I oppened issue #226 to address this before merging this test to dev.
|
@ntorresd Just pushed the latest changes based on your comments. A few of them I didn't implement, since it may make the test code unnecessarily complex. |
… compared with `expect_equal`. Added test for `plot_serosurvey` with bins
…are them against expected data
…, and `plot_rhats` Moved call to `fit_seromodel` into each test, so it can be skipped with `skip_on_cran`
Co-authored-by: Nicolás Torres Domínguez <45337127+ntorresd@users.noreply.github.com>
Co-authored-by: Nicolás Torres Domínguez <45337127+ntorresd@users.noreply.github.com>
Co-authored-by: Nicolás Torres Domínguez <45337127+ntorresd@users.noreply.github.com>
Co-authored-by: Nicolás Torres Domínguez <45337127+ntorresd@users.noreply.github.com>
Co-authored-by: Nicolás Torres Domínguez <45337127+ntorresd@users.noreply.github.com>
Co-authored-by: Nicolás Torres Domínguez <45337127+ntorresd@users.noreply.github.com>
Co-authored-by: Nicolás Torres Domínguez <45337127+ntorresd@users.noreply.github.com>
… (dev) and fix minor incompatibility Add `model_type` to `get_foi_index() call`
ntorresd
force-pushed
the
215-add-unit-test-for-visualisation-functionalities
branch
from
3da35a8 to
6004729
Compare
ntorresd
deleted the
215-add-unit-test-for-visualisation-functionalities
branch
|
This PR closes #215 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created automated tests for plotting functions.
To facilitate testing I created the following helper functions:
extract_plot_datato retrieve relevant data of a plot into a listcompare_lists_with_toleranceandexpect_lists_equal_with_toleranceto assure tests will pass on different platforms regardless of float numbers management