-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serofoi 1.0.2 release #265
Conversation
- use same ylim in foi plots for better readability - add environment cleanup at the end of each example
- use data simulation functionalities of the package to simulate the datasets in `foi_models.Rmd` examples - use same chunk structure in modelling to validate results - overall cleanup of the vignette
- Replace `prob_infected.stan` by two separate files for each type of model - Slight change to parameter order in `prob_infected_calculate`
…ation - Change how `stan_data` is constructed depending on type of model - Specify default behavior by type of model
- Use `age` for age-varying models and `years` in time-varying models in - `get_foi_central_estimates` - `plot_foi` - `plot_rhats`
- Update `R/stanmodels.R`
…th the age-varying probs
This is to avoid the message "Coordinate system already present. Adding new coordinate system, which will replace the existing one."
- add `graphics` to imports - remove `vdiffr` from suggests
At some point during a rebase I changed 1.0.1 for old 0.1.0 by mistake. 1.0.2 is the right tag
This pull request:
(Note that results may be inacurrate if you branched from an outdated version of the target branch.) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
============================================
+ Coverage 42.83% 100.00% +57.16%
============================================
Files 4 6 +2
Lines 747 1015 +268
============================================
+ Hits 320 1015 +695
+ Misses 427 0 -427 ☔ View full report in Codecov by Sentry. |
Hello. Seem ready for release! |
This pull request:
(Note that results may be inacurrate if you branched from an outdated version of the target branch.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for release
This PR corresponds to the release of serofoi 1.0.2. The most important changes had been reviewed by the development team in the development branch. See for instance:
fit_seromodel()
#213serofoi 1.0.2
New features
Serological surveys simulation functionalities
Enables the implementation of a wide variety of new models
sf_normal()
andsf_uniform()
.Breaking changes
following Vehtari et al. (2021).
Minor changes
simdata_*
datasets from the package and replaced them with code-based simulation in vignettes.Internal changes
Unit testing
fit_seromodel()
function (Add unit test forfit_seromodel()
#213).build_stan_data
and related functions (Add test for functions in build_stan_data.R #232).Refactorization of simulation examples
Documentation improvements