Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional CORS #92

Merged
merged 5 commits into from
Feb 18, 2021
Merged

Conversation

vipulchhabra99
Copy link
Contributor

@vipulchhabra99 vipulchhabra99 commented Feb 17, 2021

  • CORS support is now optional
  • add a property cors to the SecurityConfig that takes an object of the new model CORSConfig
  • CORSConfig currently has a single property enable that takes a bool and defaults to True
  • CORSConfig is open for extension in case other behavior will be implemented in the future (e.g., resource- or route-specific CORS)

Fixes #90

@vipulchhabra99 vipulchhabra99 force-pushed the CORS_seperate branch 2 times, most recently from 746f85f to 8c93196 Compare February 18, 2021 03:11
@uniqueg uniqueg changed the title refactor: Enabled Separate Configuration for CORS refactor: make CORS optional Feb 18, 2021
@uniqueg uniqueg changed the title refactor: make CORS optional feat: optional CORS\ Feb 18, 2021
@uniqueg uniqueg changed the title feat: optional CORS\ feat: optional CORS Feb 18, 2021
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks a lot :)

@uniqueg uniqueg merged commit 110e6cc into elixir-cloud-aai:dev Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS support should be optional
2 participants