CORS support should be optional #90
Labels
flag: good 1st issue
Good for newcomers
priority: medium
Medium priority
type: feature
New feature or request
workload: minutes
Likely takes minutes to resolve
Milestone
While I don't understand tne implications fully, I think [CORS][] should not be enabled for every microservice and thus should be made optional.
It's rather an easy fix but needs some changes all around (code, docstrings, possibly examples).
In principle, this is what needs to be done, as far as I can tell:
enable_cors
should be added to theSecurityConfig
model (set default toTrue
) infoca/models/config.py
; update docstring accordingly, including example and, if necessary, dependent examples (search file for any mentions ofSecurityConfig
)foca/foca.py
), the value of the config parameter should be read to decide whether to callenable_cors()
in line 49 (i.e., add anif ...
around that call and the log message, maybe add another log message to say that CORS is disabled in theelse ...
block)The text was updated successfully, but these errors were encountered: