This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Set GOCACHE to a writable existing directory, change GOPATH #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation of /projects from the GOPATH.
benoitf
approved these changes
Jun 17, 2019
|
ci-build check is that CI is not able to build from custom user branches ? |
|
ci-build |
|
Please do not merge this PR until eclipse-che/che-plugin-registry#165 is merged otherwise the plugin would be broken ( |
|
I merge this since eclipse-che/che-plugin-registry#165 was merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets
GOCACHEexplictly to a writable directory.Removes the hardcoded location of /projects from the
GOPATH. This is replaced by a dynamic resolution of/projectsfrom the Che server done in eclipse-che/che-plugin-registry#165.This is to improve experience with the go plugin. The resetting of
GOCACHEmakes the warning about a directory not being writable disappear./projectsshould not be hardcoded because it is actually configurable in the Che server.What issues does this PR fix or reference?
eclipse-che/che#13529
eclipse-che/che-plugin-registry#165