This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Adds an example project to go devfile. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metlos It would be good to see some commands, like the following /~https://github.com/eclipse/che/blob/master/ide/che-core-ide-templates/src/main/resources/samples.json#L269 |
Completely forgot about this, but now an example command is included. |
in the console.
skabashnyuk
approved these changes
Jul 3, 2019
Ohrimenko1988
added a commit
that referenced
this pull request
May 20, 2020
Ohrimenko1988
added a commit
that referenced
this pull request
Jun 1, 2020
sparkoo
pushed a commit
to sparkoo/che-devfile-registry
that referenced
this pull request
Dec 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds an example project to the Go devfile in the registry.
Note that contrary to the requirement in eclipse-che/che#13529 this PR does NOT add the /~https://github.com/xesina/golang-echo-realworld-example-app project to the devfile, because that project uses Go modules, available only in Go 1.11, while our che plugin for Go uses Go 1.10.7.
Note also that I made some slight adjustments to the plugin definition and image to ever so slightly improve the experience with them.
What issues does this PR fix or reference?
eclipse-che/che#13529
eclipse-che/che-plugin-registry#165
eclipse-che/che-theia#288