Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use safe set in client daemon network_topology.go #3276

Merged
merged 3 commits into from
May 16, 2024

Conversation

fcgxz2003
Copy link
Member

@fcgxz2003 fcgxz2003 commented May 15, 2024

Use safe set in client daemon network_topology.go.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@fcgxz2003 fcgxz2003 requested a review from a team as a code owner May 15, 2024 11:02
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.70%. Comparing base (1d96401) to head (786f835).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3276      +/-   ##
==========================================
- Coverage   52.71%   52.70%   -0.01%     
==========================================
  Files         192      192              
  Lines       20388    20388              
==========================================
- Hits        10748    10746       -2     
- Misses       8833     8837       +4     
+ Partials      807      805       -2     
Flag Coverage Δ
unittests 52.70% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/daemon/networktopology/network_topology.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Signed-off-by: XZ <834756128@qq.com>
jim3ma
jim3ma previously approved these changes May 15, 2024
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use SafeSet.

Signed-off-by: XZ <834756128@qq.com>
@fcgxz2003 fcgxz2003 changed the title fix: add null pointer judgment in client daemon network_topology.go fix: use safe set in client daemon network_topology.go May 15, 2024
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 4aa9a7e into dragonflyoss:main May 16, 2024
28 checks passed
@fcgxz2003 fcgxz2003 deleted the fix_daemon branch June 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants