-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use safe set in client daemon network_topology.go #3276
Conversation
Signed-off-by: XZ <834756128@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3276 +/- ##
==========================================
- Coverage 52.71% 52.70% -0.01%
==========================================
Files 192 192
Lines 20388 20388
==========================================
- Hits 10748 10746 -2
- Misses 8833 8837 +4
+ Partials 807 805 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: XZ <834756128@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use SafeSet
.
Signed-off-by: XZ <834756128@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use safe set in client daemon network_topology.go.
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist