fix: use safe set in client daemon network_topology.go (#3276)

Signed-off-by: XZ <834756128@qq.com>
dragonflyoss · May 16, 2024 · 4aa9a7e · 4aa9a7e
1 parent 6c44d25
commit 4aa9a7e
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/client/daemon/networktopology/network_topology.go b/client/daemon/networktopology/network_topology.go
@@ -32,6 +32,7 @@ import (
 
 	"d7y.io/dragonfly/v2/client/config"
 	logger "d7y.io/dragonfly/v2/internal/dflog"
+	"d7y.io/dragonfly/v2/pkg/container/set"
 	"d7y.io/dragonfly/v2/pkg/net/ping"
 	schedulerclient "d7y.io/dragonfly/v2/pkg/rpc/scheduler/client"
 )
@@ -154,8 +155,8 @@ func (nt *networkTopology) syncProbes() error {
 // we will send the probe result to the scheduler.
 func (nt *networkTopology) pingHosts(destHosts []*v1.Host) ([]*schedulerv1.Probe, []*schedulerv1.FailedProbe) {
 	var (
-		probes       []*schedulerv1.Probe
-		failedProbes []*schedulerv1.FailedProbe
+		probes       = set.NewSafeSet[*schedulerv1.Probe]()
+		failedProbes = set.NewSafeSet[*schedulerv1.FailedProbe]()
 	)
 
 	wg := &sync.WaitGroup{}
@@ -166,7 +167,7 @@ func (nt *networkTopology) pingHosts(destHosts []*v1.Host) ([]*schedulerv1.Probe
 
 			stats, err := ping.Ping(destHost.Ip)
 			if err != nil {
-				failedProbes = append(failedProbes, &schedulerv1.FailedProbe{
+				failedProbes.Add(&schedulerv1.FailedProbe{
 					Host: &v1.Host{
 						Id:           destHost.Id,
 						Ip:           destHost.Ip,
@@ -182,7 +183,7 @@ func (nt *networkTopology) pingHosts(destHosts []*v1.Host) ([]*schedulerv1.Probe
 				return
 			}
 
-			probes = append(probes, &schedulerv1.Probe{
+			probes.Add(&schedulerv1.Probe{
 				Host: &v1.Host{
 					Id:           destHost.Id,
 					Ip:           destHost.Ip,
@@ -199,5 +200,5 @@ func (nt *networkTopology) pingHosts(destHosts []*v1.Host) ([]*schedulerv1.Probe
 	}
 
 	wg.Wait()
-	return probes, failedProbes
+	return probes.Values(), failedProbes.Values()
 }