Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable interceptors implicitly in binder gen nupkg when generator is enabled #91469

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Sep 1, 2023

@dotnet/area-extensions-configuration @dotnet/area-infrastructure-libraries @captainsafia

@layomia layomia added this to the 8.0.0 milestone Sep 1, 2023
@layomia layomia self-assigned this Sep 1, 2023
@ghost
Copy link

ghost commented Sep 1, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #91419. RC-2 candidate.

@dotnet/area-extensions-configuration @dotnet/area-infrastructure-libraries @captainsafia

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration

Milestone: 8.0.0

@layomia layomia requested a review from ericstj September 1, 2023 17:12
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Did we test this manually? Is there a way we can add a test for this? This shouldn't block this PR though.

@layomia
Copy link
Contributor Author

layomia commented Sep 1, 2023

Yes this was manually tested; like the previous change (#84379).

Unlike the SDK (e.g. in dotnet/sdk#35024), we don't seem to have a pattern for testing inbox/nupkg target changes.

@ViktorHofer do you have thoughts on possibilities here (for future/follow-up) ?

@layomia layomia merged commit a7336b1 into dotnet:main Sep 4, 2023
@layomia
Copy link
Contributor Author

layomia commented Sep 4, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Started backporting to release/8.0: /~https://github.com/dotnet/runtime/actions/runs/6077015411

@ghost ghost locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update config binding gen nupkg transitive build target to use granular interceptor opt-in
4 participants