-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable interceptors implicitly in binder gen nupkg when generator is enabled #91469
Conversation
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsFixes #91419. RC-2 candidate. @dotnet/area-extensions-configuration @dotnet/area-infrastructure-libraries @captainsafia
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Did we test this manually? Is there a way we can add a test for this? This shouldn't block this PR though.
Yes this was manually tested; like the previous change (#84379). Unlike the SDK (e.g. in dotnet/sdk#35024), we don't seem to have a pattern for testing inbox/nupkg target changes. @ViktorHofer do you have thoughts on possibilities here (for future/follow-up) ? |
...s.Configuration.Binder/src/buildTransitive/Microsoft.Extensions.Configuration.Binder.targets
Outdated
Show resolved
Hide resolved
...s.Configuration.Binder/src/buildTransitive/Microsoft.Extensions.Configuration.Binder.targets
Outdated
Show resolved
Hide resolved
295d9d5
to
0d82573
Compare
0d82573
to
6ee347c
Compare
...s.Configuration.Binder/src/buildTransitive/Microsoft.Extensions.Configuration.Binder.targets
Outdated
Show resolved
Hide resolved
/backport to release/8.0 |
Started backporting to release/8.0: /~https://github.com/dotnet/runtime/actions/runs/6077015411 |
@dotnet/area-extensions-configuration @dotnet/area-infrastructure-libraries @captainsafia