Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable interceptors implicitly in binder gen nupkg when generator is enabled #91469

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Enable interceptors implicitly in binder gen nupkg when generator is enabled #91469

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ee347c
Enable interceptors implicitly in binder gen nupkg when generator is …
layomia Sep 1, 2023
ca45d07
Simplify impl & remove unneeded target
layomia Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...onfiguration.Binder/src/buildTransitive/Microsoft.Extensions.Configuration.Binder.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project InitialTargets="NETStandardCompatError_Microsoft_Extensions_Configuration_Binder">
<Target Name="_Microsoft_Extensions_Configuration_BinderRemoveAnalyzer"
<Target Name="_Microsoft_Extensions_Configuration_Binder_RemoveAnalyzer"
Condition="'$(EnableConfigurationBindingGenerator)' != 'true'"
AfterTargets="ResolvePackageDependenciesForBuild;ResolveNuGetPackageAssets">

Expand All @@ -8,6 +8,16 @@
</ItemGroup>
</Target>

<Target Name="_Microsoft_Extensions_Configuration_Binder_EnableInterceptors"
layomia marked this conversation as resolved.
Show resolved Hide resolved
Condition="'$(EnableConfigurationBindingGenerator)' == 'true'"
AfterTargets="ResolvePackageDependenciesForBuild;ResolveNuGetPackageAssets">
layomia marked this conversation as resolved.
Show resolved Hide resolved

<PropertyGroup>
<!-- The configuration binding source generator uses a preview version of the compiler interceptors feature. Enable it implicitly when the generator is enabled. -->
<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>
</PropertyGroup>
</Target>

<Target Name="NETStandardCompatError_Microsoft_Extensions_Configuration_Binder"
Condition="'$(SuppressTfmSupportBuildWarnings)' == ''">
<PropertyGroup>
Expand Down