Update Ruby versions #101
Update Ruby versions #101
Conversation
WalkthroughThe pull request updates multiple Dockerfiles for various Ubuntu images to install Ruby version 3.3.4 instead of previous versions (3.2.2 or 3.3.0). Each Dockerfile has been modified to change the download URL and directory names to reflect the new Ruby version. The overall installation process and other commands remain unchanged across all affected Dockerfiles. Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](/~https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Outside diff range and nitpick comments (5)
lifeboat/ubuntu/Dockerfile.focal (1)
37-38: Consider pinning package versions for reproducible builds.The current Dockerfile doesn't pin versions for installed packages, which could lead to inconsistent builds over time.
Consider adding version constraints to critical packages:
- apt-get -y install build-essential gcc g++ make libtool texinfo dpkg-dev pkg-config && \ - apt-get -y install libssl-dev zlib1g-dev libyaml-0-2 libyaml-dev && \ + apt-get -y install build-essential=12.8ubuntu1.1 gcc=4:9.3.0-1ubuntu2 g++=4:9.3.0-1ubuntu2 \ + make=4.2.1-1.2 libtool=2.4.6-14 texinfo=6.7.0.dfsg.2-5 dpkg-dev=1.19.7ubuntu3.2 pkg-config=0.29.1-0ubuntu4 \ + libssl-dev=1.1.1f-1ubuntu2.20 zlib1g-dev=1:1.2.11.dfsg-2ubuntu1.5 \ + libyaml-0-2=0.2.2-1 libyaml-dev=0.2.2-1 && \lifeboat/ubuntu/Dockerfile.lunar (2)
37-38: Add checksum verification and cleanup build artifacts.While the Ruby version update looks good, consider these security and optimization improvements:
- Verify the downloaded tarball's checksum
- Clean up build artifacts to reduce image size
- Add error handling for download and extraction
Apply this diff to implement the suggested improvements:
- cd /tmp && rm -rf ruby && wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && tar -zxvf ruby-3.3.4.tar.gz && \ - cd ruby-3.3.4 && ./configure && make install + cd /tmp && rm -rf ruby && \ + wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && \ + wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz.sha256" && \ + sha256sum -c ruby-3.3.4.tar.gz.sha256 && \ + tar -zxvf ruby-3.3.4.tar.gz && \ + cd ruby-3.3.4 && ./configure && make install && \ + cd .. && rm -rf ruby-3.3.4* && \ + apt-get clean && rm -rf /var/lib/apt/lists/*
Line range hint
1-38: Consider Dockerfile optimization best practices.To improve the Dockerfile's maintainability and reduce the image size:
- Consider combining
aptcommands to reduce layers- Pin package versions for reproducible builds
- Use
--no-install-recommendswith apt-getHere's an example of combining the first apt commands:
-RUN apt update && DEBIAN_FRONTEND=noninteractive apt -y upgrade && DEBIAN_FRONTEND=noninteractive apt -y install build-essential && DEBIAN_FRONTEND=noninteractive apt -y install tzdata +RUN apt-get update && \ + DEBIAN_FRONTEND=noninteractive apt-get -y --no-install-recommends install \ + build-essential \ + tzdata && \ + apt-get clean && \ + rm -rf /var/lib/apt/lists/*lifeboat/ubuntu/Dockerfile.noble (1)
37-38: Consider usingmake -j$(nproc)for faster builds.The current
make installcommand doesn't utilize parallel compilation. Usingmake -j$(nproc)can significantly speed up the build process.- cd ruby-3.3.4 && ./configure && make install + cd ruby-3.3.4 && ./configure && make -j$(nproc) installlifeboat/ubuntu/Dockerfile.rolling (1)
37-38: Consider using Ruby version management tools.For better version management and easier updates, consider using tools like
rbenvorrvminstead of compiling from source.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (5)
- lifeboat/ubuntu/Dockerfile.focal (1 hunks)
- lifeboat/ubuntu/Dockerfile.jammy (1 hunks)
- lifeboat/ubuntu/Dockerfile.lunar (1 hunks)
- lifeboat/ubuntu/Dockerfile.noble (1 hunks)
- lifeboat/ubuntu/Dockerfile.rolling (1 hunks)
🔇 Additional comments (2)
lifeboat/ubuntu/Dockerfile.jammy (1)
37-38: Verify Ruby installation across different architectures.The build process should be tested on different architectures to ensure compatibility.
✅ Verification successful
Multi-architecture build support is already implemented
The repository already has robust multi-architecture build support for the Ubuntu Jammy Dockerfile through the
release.multi-arch.shscript, which builds and tests the image for multiple architectures including:
- linux/arm64
- linux/amd64
- linux/s390x
- linux/ppc64le
The Ruby installation in the Dockerfile will be automatically built and tested across all these architectures through the existing CI/CD pipeline using Docker BuildX.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the Dockerfile is used in workflows for different architectures # Test: Search for workflow files that build this Dockerfile rg -l "Dockerfile.jammy" .github/workflows/ # Test: Search for platform-specific build configurations rg -A 5 "platform.*linux/(amd64|arm64)" .github/workflows/Length of output: 222
Script:
#!/bin/bash # Let's first check if there are any workflow files in the repository fd -e yml -e yaml # Check for any Docker-related build configurations rg -i "docker.*build|buildx" # Look for platform or architecture specific configurations rg -i "platform|arch|amd64|arm64"Length of output: 32045
lifeboat/ubuntu/Dockerfile.noble (1)
37-38: LGTM on Ruby version update to 3.3.4.The update uses the correct download URL from the official Ruby source.
| cd /tmp && rm -rf ruby && wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && tar -zxvf ruby-3.3.4.tar.gz && \ | ||
| cd ruby-3.3.4 && ./configure && make install |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider using multi-stage builds to reduce image size.
The current build process includes development tools and temporary files in the final image, increasing its size unnecessarily.
Consider using a multi-stage build:
FROM ubuntu:focal AS builder
ENV TZ=Asia/Tokyo
RUN apt-get update && \
DEBIAN_FRONTEND=noninteractive apt-get -y install \
build-essential gcc g++ make libtool texinfo dpkg-dev pkg-config \
libssl-dev zlib1g-dev libyaml-0-2 libyaml-dev wget
RUN cd /tmp && \
wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && \
tar -zxvf ruby-3.3.4.tar.gz && \
cd ruby-3.3.4 && \
./configure --prefix=/usr/local && \
make install
FROM ubuntu:focal
ENV TZ=Asia/Tokyo
COPY --from=builder /usr/local /usr/local
# Rest of your package installations...Add checksum verification for Ruby source.
While updating to Ruby 3.3.4 is good, it's recommended to verify the integrity of the downloaded tarball.
Apply this diff to add checksum verification:
- cd /tmp && rm -rf ruby && wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && tar -zxvf ruby-3.3.4.tar.gz && \
- cd ruby-3.3.4 && ./configure && make install
+ cd /tmp && rm -rf ruby && \
+ wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && \
+ wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz.sha256" && \
+ echo "$(cat ruby-3.3.4.tar.gz.sha256) ruby-3.3.4.tar.gz" | sha256sum --check && \
+ tar -zxvf ruby-3.3.4.tar.gz && \
+ cd ruby-3.3.4 && ./configure && make install && \
+ cd /tmp && rm -rf ruby-3.3.4* && \
+ apt-get clean && rm -rf /var/lib/apt/lists/*📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| cd /tmp && rm -rf ruby && wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && tar -zxvf ruby-3.3.4.tar.gz && \ | |
| cd ruby-3.3.4 && ./configure && make install | |
| cd /tmp && rm -rf ruby && \ | |
| wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && \ | |
| wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz.sha256" && \ | |
| echo "$(cat ruby-3.3.4.tar.gz.sha256) ruby-3.3.4.tar.gz" | sha256sum --check && \ | |
| tar -zxvf ruby-3.3.4.tar.gz && \ | |
| cd ruby-3.3.4 && ./configure && make install && \ | |
| cd /tmp && rm -rf ruby-3.3.4* && \ | |
| apt-get clean && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
@doridoridoriand、承知しました。別途Issueを作成されるとのことですね。もしよろしければ、Issueの作成をお手伝いしましょうか？
(._.)
There was a problem hiding this comment.
@coderabbitai Issueの作成お願いします
There was a problem hiding this comment.
@doridoridoriand、Issueを作成いたしました！以下のリンクからご確認ください。
ご確認よろしくお願いいたします。(^_^)
🔗 Analysis chain
@doridoridoriand、Issueを作成いたしますね。(^_^)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
gh issue create \
--title "Add checksum verification for Ruby source in Dockerfile" \
--body "As requested by @doridoridoriand in [PR #101](/~https://github.com/doridoridoriand/containers/pull/101) [comment](/~https://github.com/doridoridoriand/containers/pull/101#discussion_r1817698939), we should add checksum verification for the Ruby source tarball in the Dockerfile to improve security." \
--assignee doridoridoriand
Length of output: 471
There was a problem hiding this comment.
@doridoridoriand、ありがとうございます！お役に立てて嬉しいです。
／(=^･^=)＼
| cd /tmp && rm -rf ruby && wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && tar -zxvf ruby-3.3.4.tar.gz && \ | ||
| cd ruby-3.3.4 && ./configure && make install |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider adding checksum verification for security.
To ensure the integrity of the downloaded Ruby source, consider adding checksum verification.
- cd /tmp && rm -rf ruby && wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && tar -zxvf ruby-3.3.4.tar.gz && \
- cd ruby-3.3.4 && ./configure && make install
+ cd /tmp && rm -rf ruby && \
+ wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && \
+ wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz.sha256" && \
+ echo "$(cat ruby-3.3.4.tar.gz.sha256) ruby-3.3.4.tar.gz" | sha256sum --check && \
+ tar -zxvf ruby-3.3.4.tar.gz && \
+ cd ruby-3.3.4 && ./configure && make install && \
+ cd /tmp && rm -rf ruby-3.3.4* && \
+ apt-get clean && rm -rf /var/lib/apt/lists/*📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| cd /tmp && rm -rf ruby && wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && tar -zxvf ruby-3.3.4.tar.gz && \ | |
| cd ruby-3.3.4 && ./configure && make install | |
| cd /tmp && rm -rf ruby && \ | |
| wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz" && \ | |
| wget "https://cache.ruby-lang.org/pub/ruby/3.3/ruby-3.3.4.tar.gz.sha256" && \ | |
| echo "$(cat ruby-3.3.4.tar.gz.sha256) ruby-3.3.4.tar.gz" | sha256sum --check && \ | |
| tar -zxvf ruby-3.3.4.tar.gz && \ | |
| cd ruby-3.3.4 && ./configure && make install && \ | |
| cd /tmp && rm -rf ruby-3.3.4* && \ | |
| apt-get clean && rm -rf /var/lib/apt/lists/* |
Summary by CodeRabbit
New Features
Bug Fixes