support SELECT ... INTO OUTFILE/DUMPFILE ...
#2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ql-server into james/select-into
reltuk
reviewed
Feb 8, 2024
reltuk
reviewed
Feb 8, 2024
sql/rowexec/rel.go
Outdated
Comment on lines
542
to
544
| if _, relErr := filepath.Rel(dir.(string), fileStr); relErr != nil { | ||
| return sql.ErrSecureFilePriv.New() | ||
| } |
There was a problem hiding this comment.
This is a different check than we do on the load data infile parameter. In particular, the check we preform there has the following behavior differences:
- It doesn't allow creating files in subdirectories of
secure_file_priv - It uses
os.Open+Stat()on thefilepath.Dir()of the provided path, in addition to a Stat of thesecure_file_privdirectory, to assert that the files are in the same directory.
The end result is a difference in behavior when there are subdirectories, symlinks, etc. We should probably stick to the same behavior as the read paths?
There was a problem hiding this comment.
This should be fixed now through the isUnderSecureFileDir() function.
It checks that either the secure_file_privs directory and the outfile directory are the same or that the absolute path of secure_file_privs is a prefix to the absolute path of the outfile.
fulghum
approved these changes
Feb 8, 2024
…ql-server into james/select-into
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for MySQL's
SELECT ... INTO OUTFILE/DUMPFILE ...feature.It is the complement to
LOAD DATA. There is noLOCALoption, so files created using this feature are on the server.This PR adds a custom TestSuite for testing these files, as it needs to write, read, and delete files.
syntax: dolthub/vitess#311
fixes dolthub/dolt#7453