Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add syntax support for SELECT ... INTO OUTFILE ... options #311

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

jycor
Copy link

@jycor jycor commented Feb 7, 2024

We had parser support for SELECT ... INTO OUTFILE, but were lacking parser support for the variety of OUTFILE options.
This PR adds support for all the options and certain combinations of them.
However, we are missing support for duplicate options and certain orderings of these options; tests for these are added as error tests with a TODO.

MySQL Docs:
https://dev.mysql.com/doc/refman/8.0/en/select-into.html

MariaDB Docs (this has the actual grammar):
https://mariadb.com/kb/en/select-into-outfile/

@jycor jycor requested a review from zachmu as a code owner February 7, 2024 21:57
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hydrocharged Hydrocharged merged commit 6c93b03 into main Feb 9, 2024
4 checks passed
@Hydrocharged Hydrocharged deleted the james/select-into branch February 9, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants