Non-ambiguous ORDER BY col should not error #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Oct 20, 2023
nicktobey
reviewed
Oct 20, 2023
sql/planbuilder/parse_test.go
Outdated
| @@ -41,10 +41,23 @@ type planTest struct { | |||
|
|
|||
| func TestPlanBuilder(t *testing.T) { | |||
| var verbose, rewrite bool | |||
| //verbose = true | |||
| //rewrite = true | |||
| verbose = true | |||
nicktobey
approved these changes
Oct 20, 2023
jycor
reviewed
Oct 20, 2023
| @@ -45,6 +45,19 @@ func TestPlanBuilder(t *testing.T) { | |||
| //rewrite = true | |||
|
|
|||
| var tests = []planTest{ | |||
| { | |||
There was a problem hiding this comment.
This apparently works in MySQL
select t1.x as x, t1.x as x from xy t1, xy t2 order by x;
but this fails in MySQL
select t1.x as x, t2.x as x from xy t1, xy t2 order by x;
I think they both fail in dolt even with your fix.
Also should make sure
select x, y as x from xy order by x;
still fails
There was a problem hiding this comment.
good catch, take another peek see if the solution's OK
There was a problem hiding this comment.
I previously outlined the exact resolution rules for ORDER BY in MySQL here: dolthub/dolt#6676
max-hoffman
force-pushed
the
max/order-by-ambiguity-bug
branch
from
e4cddae to
86deb33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.