Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
Reverting this commit after receiving customer testing feedback that there are still cases where we aren't finding the most specific commit and that query latency for some
dolt_diff_<tablename>
queries has increased.This reverts commit 2e5e6aa968c645d150ba112a6d507b3d516f296c
This allows the engine to differentiate between tables with the same name from different databases, in line with MySQL. This also moves us toward a less error-prone model for resolving table references in queries, where we generate IDs for tables and columns during plan building and use those instead of doing lots of string comparisons.
The main reason for supporting this is that it allows writing queries like:
SELECT * from `db/main`.table join `db/dev`.table using (pk)
without having to put each branch in its own subquery.
This is the dolt side of Allow queries with duplicate table names if those tables come from different databases and all references are unambiguously resolvable. dolthub/go-mysql-server#2090
go-mysql-server
Closed Issues
dolt_diff_<table>