Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add alternative type check for auto_increment type validation #7688

Merged
merged 1 commit into from
Apr 3, 2024
Merged

add alternative type check for auto_increment type validation #7688

merged 1 commit into from
Apr 3, 2024

Conversation

jennifersp
Copy link
Contributor

No description provided.

@jennifersp jennifersp requested a review from Hydrocharged April 3, 2024 07:12
Hydrocharged
Hydrocharged approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Contributor

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e5fbbdc ok 5937457
version total_tests
e5fbbdc 5937457
correctness_percentage
100.0

@jennifersp jennifersp merged commit 3762503 into main Apr 3, 2024
33 of 34 checks passed
@jennifersp jennifersp deleted the jennifer/auto-inc-check branch April 3, 2024 14:38
@BrewTestBot BrewTestBot mentioned this pull request Apr 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennifersp @coffeegoddd @Hydrocharged