Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt 1.35.8 #168170

Merged
merged 2 commits into from
Apr 6, 2024
Merged

dolt 1.35.8 #168170

merged 2 commits into from
Apr 6, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
# Merged PRs

dolt

go-mysql-server

  • 2437: lowercase when looking up self referential foreign key columns
    fixes: self referential foreign key is case sensitive dolthub/dolt#7700
  • 2436: Making @@server_id default value match MySQL
  • 2434: Fixing the default value for the binlog_checksum system variable
    Small change to make the default value of the global binlog_checksum system variable match MySQL's default value (i.e. "CRC32").
  • 2433: NULL to nil
    The SHOW FIELDS/COLUMNS FROM <table> query would return the string "NULL" for Default column rather than nil.
    This mattered for Knex, which relied on it being NULL and not "NULL".
    fixes: Show fields returns 'NULL' (in quotes) dolthub/dolt#7692
  • 2432: support Threads_connected and Threads_running status variables
    This PR adds support for Threads_connected and Threads_running status variables.
    Additionally, the local enginetest are flaking consistently in dolt ci, so those have been removed;
    we have handler tests for com_delete, com_insert, and com_update anyway.
    Related: Initial support for show status dolthub/dolt#7646
  • 2431: Setting Innodb_buffer_pool_pages_total to 1, to avoid an issue with Datadog's collector
    Datadog's metric collector errors out with a divide by zero error if the Innodb_buffer_pool_pages_total status variable is 0; changing it to 1 avoids this and allows the agent to collect metrics from Dolt.
  • 2430: have status variables use go routines
    This PR changes Status Variables to update through go routines, to avoid slowing down query execution due to the mutexes present.
  • 2426: use @@session.collation_server during create database ...
    This PR makes it so create database ... actually reads the @@session.collation_server variable.
    Additionally, this ensures that settings @@character_set_server sets @@collation_server and vice versa.
    Interestingly, it seems like MySQL actually ignores the global scope of these system variables, and reads the session scope instead.
    fixes set global character_set_server not working the same way in MySQL, may lead inconsistency dolthub/dolt#7651

vitess

  • 329: Changes to binlog event creation functions
    • Exposing the Length() function in the BinlogEvent interface so calling code can access the event size present in a binlog event's header. Needed for calculating binlog file position.
    • Renaming FakeBinlogStreamBinlogStream so calling code can use it when serializing binlog events.
  • 328: revert decimals
    issue: revert decimals dolthub/vitess#328

Closed Issues

  • 7700: self referential foreign key is case sensitive
  • 7649: Questions about Dolt
  • 7651: set global character_set_server not working the same way in MySQL, may lead inconsistency
  • 6320: dolt verify-contraints does not check unique constraints
  • 7692: Show fields returns 'NULL' (in quotes)
  • 7665: Error 1105: type time.Time not supported as bind var

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Apr 6, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 6, 2024
@BrewTestBot BrewTestBot enabled auto-merge April 6, 2024 01:21
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 6, 2024
Merged via the queue into master with commit 30643c9 Apr 6, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-dolt-1.35.8 branch April 6, 2024 01:29
@github-actions github-actions bot added the outdated PR was locked due to age label May 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants