[Dojo] add dojo-core interfaces into their file + snake_case contracts #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The snake_casing of the world and executor contracts has an impact on the dojo-lang and dojo-world. Modifications were made accordingly + refacto into constants to allow future changes
glihm
commented
Jun 30, 2023
crates/dojo-world/src/manifest.rs
Outdated
| calldata: vec
|
awesome thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow your comment @tarrencev I've moved the interfaces into their respective file.
Also, as I saw your snake_casing initiative, I have done it too.
By the way, the snake_casing of the world and executor contracts has an impact on the dojo-lang and dojo-world.
Modifications were made accordingly + refacto into constants to allow future changes.
Let me know if it's wasn't planned, and I'll remove this snake_casing. 👍