refacto(dojo): implement interfaces for dojo-core contracts

[glihm]

Few remarks on this refacto related to #578:

1. emit method of World conflicts with EventEmitter:

   Ambiguous method call. More than one applicable trait function with a suitable self type
   was found: IWorld::emit and EventEmitter::emit. Consider adding type annotations or
   explicitly refer to the impl function.

   I see two options here:

   • Using the explicit type each time we want to emit an event in IWorld interface impl.
     EventEmitter::emit(ref self, Struct {...});

   • Rename emit -> emit_event for IWorld. (I have tried this way, let me know if you prefer the first one, as perhaps this will break the interface used by other games).

2. During the implementation, I mostly trust the already existing code inside the contracts instead of the interfaces. And I updated the interfaces to match the contracts. Is that ok for you?

3. Add consistency to the documentation of the functions.

[tarrencev]

Thank you for this!

Few remarks on this refacto related to #578:

1. emit method of World conflicts with EventEmitter:

   Ambiguous method call. More than one applicable trait function with a suitable self type
   was found: IWorld::emit and EventEmitter::emit. Consider adding type annotations or
   explicitly refer to the impl function.

   I see two options here:

   • Using the explicit type each time we want to emit an event in IWorld interface impl.
     EventEmitter::emit(ref self, Struct {...});
   • Rename emit -> emit_event for IWorld. (I have tried this way, let me know if you prefer the first one, as perhaps this will break the interface used by other games).

I would prefer the first approach here, so we can keep the public interface clean

2. During the implementation, I mostly trust the already existing code inside the contracts instead of the interfaces. And I updated the interfaces to match the contracts. Is that ok for you?

Yup that makes sense!

3. Add consistency to the documentation of the functions.

❤️

[glihm]

@tarrencev I updated with EventEmitter to ensure that the interface is kept clean as you mentioned. 👍

[tarrencev]

As a follow up, it would be great to move these to the implementation's file

[glihm]

I have open #588 @tarrencev to follow up this topic.