This repository has been archived by the owner on Sep 12, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker-DCO-1.1-Signed-off-by: Mangled Deutz <olivier@webitup.fr> (github: dmp42)
Docker-DCO-1.1-Signed-off-by: Mangled Deutz <olivier@webitup.fr> (github: dmp42)
Docker-DCO-1.1-Signed-off-by: Mangled Deutz <olivier@webitup.fr> (github: dmp42)
- replace get(key) and ['key'] calls by dotted notation - removed defaults from the codebase (as they now all live in the config) - tweak existence tests - simplified calls to load() when possible - assume proper typage Docker-DCO-1.1-Signed-off-by: Mangled Deutz <olivier@webitup.fr> (github: dmp42)
+ enhanced typage tests Docker-DCO-1.1-Signed-off-by: Mangled Deutz <olivier@webitup.fr> (github: dmp42)
Docker-DCO-1.1-Signed-off-by: Mangled Deutz <olivier@webitup.fr> (github: dmp42)
Docker-DCO-1.1-Signed-off-by: Mangled Deutz <olivier@webitup.fr> (github: dmp42)
Docker-DCO-1.1-Signed-off-by: Mangled Deutz <olivier@webitup.fr> (github: dmp42)
Thanks for keeping me happy 👍 Nice work, this pull request LGTM. |
Docker-DCO-1.1-Signed-off-by: Mangled Deutz <olivier@webitup.fr> (github: dmp42)
Nice! 👍 |
Docker-DCO-1.1-Signed-off-by: Olivier Gambier <olivier@docker.com> (github: dmp42)
@shin- ping |
LGTM |
Merged
This was referenced Aug 1, 2014
gierschv
added a commit
to ovh/docker-registry-driver-swift
that referenced
this pull request
Aug 14, 2014
The docker-registry-core >= 2.0.0 (docker-registry >= 0.8) breaks the compatibility with the config usage (docker-archive/docker-registry#444) This commit fixes bacongobbler#12 Signed-off-by: Vincent Giersch <vincent.giersch@ovh.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly to fix our various problems with configuration typage/env that grew sore in the aftermath of the standalone True debacle:
Incidentally, this also lay code to fix #440 and does fix #442.
BEWARE that the Configuration object behavior changed and that this may have unexpected and tricky impact, so, please review (ping my favorites-eagle-eyed reviewers @shin- and @wking) and if possible test.
Please note I'm not changing for the sake of it - I'm changing so that we have something that behaves rationally - and that we know exactly how.
In a nutshell:
MY_ENV_VAR=True
will giveTrue
andMY_ENV_VAR='["foo", "bar"]'
will give a python list, etccfg.foo.bar.baz
get
methodNone
common
flavor is no longer forcefully inherited inside python code, but the heritage is declared using YAML - this is DEFINITELY a point where you need to update configuration files and that will break for people not paying attentionNone
) - this is an important change from the previous behavior where falsy values would mean the key is not returned at all (propagating to the parent dict which in turn might have returnedNone
previously if no key were Trusy). This is especially true for the mirroring and cache config (code has been adjusted)@shin-: do we need
config/config_mirroring.yml
anymore? or can I remove it?