Skip to content
This repository has been archived by the owner on Jul 8, 2021. It is now read-only.

Registry 0.8 release and API breaking changes (config) #12

Closed
dmp42 opened this issue Aug 3, 2014 · 1 comment · Fixed by #16
Closed

Registry 0.8 release and API breaking changes (config) #12

dmp42 opened this issue Aug 3, 2014 · 1 comment · Fixed by #16

Comments

@dmp42
Copy link
Collaborator

dmp42 commented Aug 3, 2014

Hey there :-)

Have a look here:
docker-archive/docker-registry#444

How does this concern you?

  • myvar = cfg.get(key, DEFAULT) no longer exist - just replace these calls with myvar = cfg.key or DEFAULT for the same effect
  • values (be they default in config.yaml or sourced from ENV) are now typed properly (eg: they are YAML evaluated), so, you likely can drop any explicit cast you had to introduce earlier

As these changes are breaking drivers, the core version will get bumped (2.0.0).

So, your new version, instead of depending on docker-registry-core>=1,<2 should then depend on docker-registry-core>=2,<3.

Note that core is not yet on pypi. If you want to test that, you have to cd docker-registry/depends/core and pip install . manually.

Wether you want to keep maintaining things for the 0.7 (core 1.0) branch, or drop it and only support 0.8 (core 2.0) is up to you, but either way, I encourage you to say something in your readme about it.

I will ping again you as soon as 0.8 is released and available
Hope that this early heads-up will help!

Cheers.

@bacongobbler
Copy link
Owner

thanks for the heads up @dmp42. I'll probably just cut a new release for v0.8.x support and let users know to stick with v0.1.0 for v0.7.0 support. If something's broken in v0.1.0, we can always push a patch release.

gierschv added a commit to ovh/docker-registry-driver-swift that referenced this issue Aug 14, 2014
The docker-registry-core >= 2.0.0 (docker-registry >= 0.8) breaks the
compatibility with the config usage (docker-archive/docker-registry#444)

This commit fixes bacongobbler#12

Signed-off-by: Vincent Giersch <vincent.giersch@ovh.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants