Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset settings not working properly due to url encoding #10000

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Sep 30, 2024

Ticket

MD-521

Description

Reset settings is not working properly for settings without skipUrlEncoding.
This happens because when reseting, we didn't reset the url query, so after refresh, we read from url query and set those settings again.

Test Plan

Navigate to trial logs page, apply some filter, then reset filters.
Before this change, the reset button would show up again. With this change, the settings would be actually reset.
Similar behavior happens at the model registry page too.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@gt2345 gt2345 requested a review from a team as a code owner September 30, 2024 16:30
@gt2345 gt2345 requested a review from johnkim-det September 30, 2024 16:30
@cla-bot cla-bot bot added the cla-signed label Sep 30, 2024
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 65b5553
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66fad21be34f340008c3b5eb
😎 Deploy Preview https://deploy-preview-10000--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.56%. Comparing base (8ab2145) to head (65b5553).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10000      +/-   ##
==========================================
- Coverage   54.59%   50.56%   -4.04%     
==========================================
  Files        1258      949     -309     
  Lines      157136   128544   -28592     
  Branches     3617     3618       +1     
==========================================
- Hits        85795    64995   -20800     
+ Misses      71208    63416    -7792     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/hooks/useSettings.ts 97.46% <100.00%> (+0.01%) ⬆️

... and 309 files with indirect coverage changes

Copy link
Contributor

@ashtonG ashtonG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for bearing with me -- lgtm!

@gt2345 gt2345 merged commit 7f88390 into main Oct 1, 2024
92 of 104 checks passed
@gt2345 gt2345 deleted the gt/521-usesettings-reset branch October 1, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants