fix: reset settings not working properly due to url encoding #10000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
MD-521
Description
Reset settings is not working properly for settings without
skipUrlEncoding
.This happens because when reseting, we didn't reset the url query, so after refresh, we read from url query and set those settings again.
Test Plan
Navigate to trial logs page, apply some filter, then reset filters.
Before this change, the reset button would show up again. With this change, the settings would be actually reset.
Similar behavior happens at the model registry page too.
Checklist
docs/release-notes/
See Release Note for details.