-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support arrow view types #533
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
==========================================
- Coverage 80.58% 80.55% -0.03%
==========================================
Files 63 63
Lines 13762 13768 +6
Branches 13762 13768 +6
==========================================
+ Hits 11090 11091 +1
- Misses 2113 2117 +4
- Partials 559 560 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good in isolation, but for completeness we should add the corresponding expression eval support to arrow_data.rs -- preferably with at least basic unit testing since we don't seem to have any code in kernel that would exercise it otherwise. We don't want to misuse delta-rs (or its users) as our unit test harness.
For that I don't really have time since I can only work on it in my weekends when I have spare time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending follow-up issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks! I filled #541 to track adding evaluation support for this.
I've added support for view type passthrough some time ago in delta-rs. Arrow-rs finally catched up and FFI support was added for view types as well.
I wanted to add enable view types export in polars during delta writes but delta-kernel-rs unfortunately hasn't the support yet:
SchemaMismatchError: Invalid data type for Delta Lake: Utf8View
This adds the view types as part of the conversion