chore: bump kernel #3036
Closed
chore: bump kernel #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
roeap,
rtyler and
hntd187
as code owners
ion-elgreco
force-pushed
the
Bump-it-up
branch
from
b121c1b to
629dd3e
Compare
ion-elgreco
force-pushed
the
Bump-it-up
branch
from
b54079a to
8e6a8b7
Compare
ion-elgreco
force-pushed
the
Bump-it-up
branch
from
8e6a8b7 to
063e0ae
Compare
rtyler
previously approved these changes
Dec 1, 2024
hntd187
reviewed
Dec 2, 2024
| @@ -542,6 +542,7 @@ impl<'a> DeltaScanBuilder<'a> { | |||
| .filter | |||
| .map(|expr| context.create_physical_expr(expr, &df_schema).unwrap()); | |||
|
|
|||
| // dbg!(logical_filter.clone()); | |||
There was a problem hiding this comment.
We prolly don't need these now ?
There was a problem hiding this comment.
I was debugging a regression caused by the kernel bump. There is something wrong with the statistics being passed to Datafusion
roeap
reviewed
Dec 11, 2024
| @@ -803,16 +810,16 @@ mod datafusion { | |||
| lazy_static::lazy_static! { | |||
| static ref ROW_COUNTS_EVAL: Arc<dyn ExpressionEvaluator> = ARROW_HANDLER.get_evaluator( | |||
| crate::kernel::models::fields::log_schema_ref().clone(), | |||
| Expression::column("add.stats_parsed.numRecords"), | |||
| Expression::column(vec!["add.stats_parsed.numRecords"].into_iter()), | |||
There was a problem hiding this comment.
I think this may be the cause for the failing DF tests.
Suggested change
| Expression::column(vec!["add.stats_parsed.numRecords"].into_iter()), | |
| Expression::column(["add", "stats_parsed", "numRecords"]), |
auto-merge was automatically disabled
December 11, 2024 14:28
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change: delta-io/delta-kernel-rs#533 and this change: #2738, we fully support view types.
I'll make a change also upstream in polars to change the arrow compat level to latest
Related Issue(s)