[Cloudflare] Remove netlify #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for decent-interface-dev failed. Why did it fail? →
|
adamgall
force-pushed
the
cf/new-demo-mode
branch
from
46bb520 to
0cea7fc
Compare
adamgall
force-pushed
the
cf/remove-netlify
branch
from
e917cb7 to
ad6bf5b
Compare
Deploying decent-interface with
|
| Latest commit: |
8763c18
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3e806634.decent-interface.pages.dev |
| Branch Preview URL: | https://cf-remove-netlify.decent-interface.pages.dev |
adamgall
force-pushed
the
cf/new-demo-mode
branch
from
0cea7fc to
b5e6d69
Compare
adamgall
force-pushed
the
cf/remove-netlify
branch
3 times, most recently
from
6d789a4 to
47e53cd
Compare
adamgall
force-pushed
the
cf/new-demo-mode
branch
from
b5e6d69 to
49e2afb
Compare
adamgall
force-pushed
the
cf/remove-netlify
branch
2 times, most recently
from
92dfb9c to
3f82e36
Compare
adamgall
force-pushed
the
cf/remove-netlify
branch
from
3f82e36 to
2188358
Compare
adamgall
force-pushed
the
cf/remove-netlify
branch
from
2188358 to
91a63ec
Compare
mudrila
approved these changes
Jan 16, 2025
.env
Outdated
| # IPFS pinning | ||
| VITE_APP_INFURA_IPFS_API_KEY="" | ||
| # IPFS pinning | ||
| VITE_APP_INFURA_IPFS_API_SECRET="" | ||
|
|
||
| # App name displayed as Title | ||
| VITE_APP_NAME="Decent" |
There was a problem hiding this comment.
Why do we need this one? Don't feel like it's reasonable to have it in env variable
There was a problem hiding this comment.
I'd say we need it because it's a global level configuration string that is used in multiple places throughout the app.
If not stored as an Env Var, what would we do instead?
There was a problem hiding this comment.
Just a constant somewhere
My point is that it is not environment-dependant - app name is always Decent for every environment
There was a problem hiding this comment.
Yeah so I hear you, but I would argue to keep it here because:
- we use it multiple times in the
index.htmlfile, and in there we do have access to environment variables, but we don't have access to any javascript code - also, by setting
VITE_APP_NAME="Decent"in the.envfile, the build system will pick up"Decent"if it's not overridden in a real environment variable
Da-Colon
approved these changes
Jan 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally removes Netlify from the codebase.
My plan is to merge this (assuming approvals) on Sunday Night January 19th and shut down the Netlify sites at that time.