Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat NodeJS failure email subject #4770

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

hqpho
Copy link
Contributor

@hqpho hqpho commented Dec 4, 2024

Right now, failures in different environments are lumped into the same thread in the Google Groups UI. b/253630058 explains that this is because anything in square brackets at the start of the subject line is ignored.

Right now, failures in different environments are lumped into the same thread in the Google Groups UI. b/253630058 explains that this is because of square brackets.
@hqpho hqpho requested a review from chejennifer December 4, 2024 21:42
Copy link
Contributor

@chejennifer chejennifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find, thanks for fixing!

@hqpho hqpho merged commit 5545946 into datacommonsorg:master Dec 4, 2024
8 checks passed
@hqpho hqpho deleted the nodeJsSubject branch December 4, 2024 22:03
gmechali pushed a commit to gmechali/website that referenced this pull request Dec 5, 2024
Right now, failures in different environments are lumped into the same
thread in the Google Groups UI. b/253630058 explains that this is
because anything in square brackets at the start of the subject line is
ignored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants