Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat NodeJS failure email subject #4770

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Reformat NodeJS failure email subject #4770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6d8e8c
Reformat NodeJS failure email subject
hqpho Dec 4, 2024
767c2f0
Merge branch 'master' into nodeJsSubject
hqpho Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tools/nl/nodejs_query_differ/differ.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ class Mode:
_GOLDEN_FOLDER = 'goldens'
_DIFF_SUCCESS_MSG = 'Success'
_EMAIL_SUBJECT_KEY = 'subject'
_EMAIL_SUBJECT_TEMPLATE = '[{env}] Failure: Nodejs Query Test'
# Use parentheses instead of square brackets to wrap env because otherwise
# Google Groups will ignore that part of the subject when deciding how to
# group conversations.
_EMAIL_SUBJECT_TEMPLATE = '({env}) Failure: Nodejs Query Test'
_EMAIL_MESSAGE_KEY = 'message'
_EMAIL_MESSAGE_TEMPLATE = 'There were diffs found when testing Nodejs Query results against goldens in {env}.<br><br><b>Nodejs Query Results</b>: {test_path}<br><b>Diff results</b>: {results_path}<br>Instructions for debugging: https://playbooks-preview.corp.google.com/datacommons/index.md?cl=head#debugging-nodejs-query-diffs'

Expand Down
Loading