Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): migrate electron-packager to @electron/packager 18.3.4 #30156

Conversation

MikeMcC399
Copy link
Contributor

Additional details

Replace the deprecated npm module electron-packager 17.1.2 in packages/electron with the renamed module @electron/packager 18.3.4.

The npm module electron-packager is deprecated and shows the message:

Please use @electron/packager moving forward. There is no API change, just a package name change

Steps to test

git clean -xfd
yarn
yarn workspace @packages/electron build
yarn workspace @packages/electron test

How has the user experience changed?

No change to user experience.

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane
Copy link
Member

Running tests

@MikeMcC399
Copy link
Contributor Author

All tests have passed
image

Updating branch again.

@MikeMcC399 MikeMcC399 marked this pull request as draft September 4, 2024 12:29
@MikeMcC399 MikeMcC399 force-pushed the issue-30124-electron-packager-to-18.3.4 branch from 7312daa to 722b56d Compare September 4, 2024 16:09
@MikeMcC399 MikeMcC399 force-pushed the issue-30124-electron-packager-to-18.3.4 branch from 722b56d to 7385ee0 Compare September 4, 2024 16:28
@MikeMcC399 MikeMcC399 marked this pull request as ready for review September 4, 2024 16:28
@MikeMcC399 MikeMcC399 marked this pull request as draft September 4, 2024 16:58
@jennifer-shehane
Copy link
Member

@MikeMcC399 Hmm, that's not a typical error I see. Unsure if it's related.

Screenshot 2024-09-04 at 1 12 11 PM

@MikeMcC399 MikeMcC399 marked this pull request as ready for review September 5, 2024 06:40
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Hmm, that's not a typical error I see. Unsure if it's related.

I suggest to run the tests again to see if the error is reproducible.

@MikeMcC399
Copy link
Contributor Author

I successfully ran

yarn binary-build
yarn binary-package
yarn binary-zip

according to /~https://github.com/cypress-io/cypress/blob/develop/guides/building-release-artifacts.md

@jennifer-shehane
Copy link
Member

@MikeMcC399 Running tests

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcC399

This comment was marked as resolved.

@jennifer-shehane
Copy link
Member

@MikeMcC399 Could you please pause on pulling in develop?

@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Sep 13, 2024

@jennifer-shehane

Could you please pause on pulling in develop?

Paused.

Should I leave this completely to you now? Just let me know if / when I should do anything else.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

A new version was released on Sep 11, 2024:

/~https://github.com/electron/packager/releases/tag/v18.3.5

Do you want to update to this one whilst the PR is still open?

@jennifer-shehane
Copy link
Member

Let just get this in since it's been open for so long and now rdy

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Let just get this in since it's been open for so long and now rdy

That's fine. I just wanted to check with you. Renovate can probably take care of bumping to the latest if it's needed at any time.

@jennifer-shehane jennifer-shehane merged commit c3b6a79 into cypress-io:develop Sep 17, 2024
70 checks passed
@MikeMcC399 MikeMcC399 deleted the issue-30124-electron-packager-to-18.3.4 branch September 17, 2024 15:10
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 25, 2024

Released in 13.15.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.15.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated electron-packager
5 participants