-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): migrate electron-packager to @electron/packager 18.3.4 #30156
chore(deps): migrate electron-packager to @electron/packager 18.3.4 #30156
Conversation
|
Running tests |
7312daa
to
722b56d
Compare
722b56d
to
7385ee0
Compare
@MikeMcC399 Hmm, that's not a typical error I see. Unsure if it's related. |
I suggest to run the tests again to see if the error is reproducible. |
I successfully ran yarn binary-build
yarn binary-package
yarn binary-zip according to /~https://github.com/cypress-io/cypress/blob/develop/guides/building-release-artifacts.md |
@MikeMcC399 Running tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting breaking changes in 18: /~https://github.com/electron/packager/releases/tag/v18.0.0
This comment was marked as resolved.
This comment was marked as resolved.
@MikeMcC399 Could you please pause on pulling in develop? |
Paused. Should I leave this completely to you now? Just let me know if / when I should do anything else. |
A new version was released on Sep 11, 2024: /~https://github.com/electron/packager/releases/tag/v18.3.5 Do you want to update to this one whilst the PR is still open? |
Let just get this in since it's been open for so long and now rdy |
That's fine. I just wanted to check with you. Renovate can probably take care of bumping to the latest if it's needed at any time. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
electron-packager
#30124Additional details
Replace the deprecated npm module electron-packager
17.1.2
in packages/electron with the renamed module @electron/packager 18.3.4.The npm module electron-packager is deprecated and shows the message:
Steps to test
git clean -xfd yarn yarn workspace @packages/electron build yarn workspace @packages/electron test
How has the user experience changed?
No change to user experience.
PR Tasks
cypress-documentation
?type definitions
?