-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: Fix some a11y violations using Cypress Cloud #28628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 flaky tests on run #53375 ↗︎
Details:
commands/waiting.cy.js • 1 flaky test • 5x-driver-electron
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
Review all test suite changes for PR #28628 ↗︎ |
jennifer-shehane
changed the title
misc: Attempt to fix a11y violations using Cypress Cloud
misc: Fix some a11y violations using Cypress Cloud
Jan 9, 2024
mschile
approved these changes
Jan 9, 2024
AtofStryker
approved these changes
Jan 9, 2024
packages/frontend-shared/src/gql-components/topnav/PromptContent.vue
Outdated
Show resolved
Hide resolved
…nt.vue Co-authored-by: Bill Glesias <bglesias@gmail.com>
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Playing around with our early access accessibility checks in the Cypress Cloud to see what the workflow is like to fix them and maybe fix some violations also.
Fixing the following a11y violations found in the Cloud.
Steps to test
This upped our a11y coverage on the launchpad tests from 98% to 99% (excludes contrast color checking for now)
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?