Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Fix some a11y violations using Cypress Cloud #28628

Merged
merged 9 commits into from
Jan 10, 2024
Merged

misc: Fix some a11y violations using Cypress Cloud #28628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f9732fd
Attempt to fix a11y violation with aria role of expanded state
jennifer-shehane Jan 3, 2024
85749e1
empty commit
jennifer-shehane Jan 3, 2024
49a37f4
Add role for option that is in framework dropdown to address a11y vio…
jennifer-shehane Jan 3, 2024
eab3db9
Add alt text for CI provider images
jennifer-shehane Jan 3, 2024
38453aa
Add aria-label to readonly label for a11y
jennifer-shehane Jan 3, 2024
6ace0f5
Add title to stub to reflect title addition in services
jennifer-shehane Jan 4, 2024
e914f28
Merge branch 'develop' into a11y-fixes
jennifer-shehane Jan 9, 2024
f10915c
Add changelog entry
jennifer-shehane Jan 9, 2024
de5c9f9
Update packages/frontend-shared/src/gql-components/topnav/PromptConte…
jennifer-shehane Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ _Released 1/16/2024 (PENDING)_

**Misc:**

- Improved accessibility of some areas of the Cypress App. Addressed in [#28628](/~https://github.com/cypress-io/cypress/pull/28628).
- Updated some documentation links to go through on.cypress.io. Addressed in [#28623](/~https://github.com/cypress-io/cypress/pull/28623).

## 13.6.2
Expand Down
1 change: 1 addition & 0 deletions packages/frontend-shared/cypress/support/mock-graphql/stubgql-Query.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export const stubQuery: MaybeResolver<Query> = {
videoEmbedHtml () {
return `<iframe
src="https://player.vimeo.com/video/855168407?h=0cbc785eef"
title="Video about what is new in Cypress"
class="rounded h-full bg-gray-1000 w-full"
frameborder="0"
allow="autoplay; fullscreen; picture-in-picture"
Expand Down
1 change: 1 addition & 0 deletions packages/frontend-shared/src/components/Collapsible.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
>
<div
data-cy="collapsible-header"
role="button"
:aria-expanded="isOpen"
class="rounded-t focus:outline-indigo-500"
:class="{'rounded-b': !isOpen}"
Expand Down
1 change: 1 addition & 0 deletions packages/frontend-shared/src/components/TerminalPrompt.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
:value="command"
data-cy="terminal-prompt-input"
class="border-none flex-1"
aria-label="Terminal command"
>
<div class="font-sans">
<CopyButton
Expand Down
1 change: 1 addition & 0 deletions packages/frontend-shared/src/gql-components/topnav/PromptContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<img
:src="provider.icon"
width="14"
:alt="`${provider.name} logo`"
>
</template>
{{ provider.name }}
Expand Down
2 changes: 1 addition & 1 deletion packages/launchpad/src/setup/FrameworkOptionsFooter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<template>
<template role="option">
<div class="flex bg-gray-50 h-[48px] py-[12px] px-[17px] text-gray-800 items-center">
<div>
<Icon
Expand Down
Loading