test: fix flaky CT test by relying on query

[ZachJW34]

Additional details

Steps to test

Flaky CT test: https://app.circleci.com/pipelines/github/cypress-io/cypress/49140/workflows/282c3bcc-d3d6-4b1f-b6a8-93fc588b7935/jobs/2043536/parallel-runs/1?filterBy=FAILED

Doing what the comment in CI says and converting to query

How has the user experience changed?

na

PR Tasks

• Have tests been added/updated?
• [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[mike-plummer]

Looks good and works locally, thanks for tackling flake! 💯

Only comment (which isn't related to your change) is that the test you're touching looks to have a bad name. Doesn't seem to do anything related to the UTM param, so either that's missing from the test or it needs a new name. If you feel like messing with it while you're in there, cool, if not that's cool too

[cypress]

7 flaky tests on run #43803 ↗︎

0

5100

74

0

7

Details:

test: fix flaky CT test by relying on query
Project: cypress	Commit: e57e4dae8a
Status: Passed	Duration: 13:53 💡
Started: Feb 6, 2023 12:38 AM	Ended: Feb 6, 2023 12:52 AM

  e2e/origin/cookie_behavior.cy.ts • 4 flaky tests • 5x-driver-electron

View Output Video

Test
... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)

  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test
... > correctly returns currentRetry
... > correctly returns currentRetry
... > correctly returns currentRetry

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[lmiller1990]

Looks good

Agreed with Mike... data-cy="button" is probably not a great name for a test element. I'd really like to see this merged, though, and don't think it's a blocker.

[ZachJW34]

@lmiller1990 @mike-plummer the test is related to UTM parameter as it's testing that the slot generated by this component gets the UTM parameter passed to it (JSX props in the test). The data-cy="button" isn't great but it's only added to the JSX test slot, not code that's in production